add computing PublicKeyPackage from commitments #1003
conradoplg
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
2 errors and 5 warnings
|
use of `or_insert_with` to construct default value:
frost-core/src/tests/ciphersuite_generic.rs#L408
error: use of `or_insert_with` to construct default value
--> frost-core/src/tests/ciphersuite_generic.rs:408:18
|
408 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
|
|
incorrect implementation of `partial_cmp` on an `Ord` type:
frost-core/src/frost/identifier.rs#L132
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> frost-core/src/frost/identifier.rs:132:1
|
132 | / impl<C> PartialOrd for Identifier<C>
133 | | where
134 | | C: Ciphersuite,
135 | | {
136 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
| | _______________________________________________________________________-
137 | || let serialized_self = <<C::Group as Group>::Field>::little_endian_serialize(&self.0);
138 | || let serialized_other = <<C::Group as Group>::Field>::little_endian_serialize(&other.0);
139 | || // The default cmp uses lexicographic order; so we need the elements in big endian
... ||
144 | || .partial_cmp(serialized_other.as_ref().iter().rev())
145 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
146 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
= note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
|
|
Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|