add computing PublicKeyPackage from commitments #1003
This check has been archived and is scheduled for deletion.
Learn more about checks retention
GitHub Actions / Clippy (stable) Results
failed
Oct 17, 2023 in 1s
Clippy (stable) Results
2 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 2 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check failure on line 408 in frost-core/src/tests/ciphersuite_generic.rs
github-actions / Clippy (stable) Results
use of `or_insert_with` to construct default value
error: use of `or_insert_with` to construct default value
--> frost-core/src/tests/ciphersuite_generic.rs:408:18
|
408 | .or_insert_with(BTreeMap::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
Check failure on line 146 in frost-core/src/frost/identifier.rs
github-actions / Clippy (stable) Results
incorrect implementation of `partial_cmp` on an `Ord` type
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> frost-core/src/frost/identifier.rs:132:1
|
132 | / impl<C> PartialOrd for Identifier<C>
133 | | where
134 | | C: Ciphersuite,
135 | | {
136 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
| | _______________________________________________________________________-
137 | || let serialized_self = <<C::Group as Group>::Field>::little_endian_serialize(&self.0);
138 | || let serialized_other = <<C::Group as Group>::Field>::little_endian_serialize(&other.0);
139 | || // The default cmp uses lexicographic order; so we need the elements in big endian
... ||
144 | || .partial_cmp(serialized_other.as_ref().iter().rev())
145 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
146 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
= note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
Loading