Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - JS-SDK Error handling #4

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

Musilah
Copy link
Contributor

@Musilah Musilah commented Oct 16, 2023

What does this do?

  1. Introduces functionality to the errors.js file
  2. Allows error handling for JS-SDK
  3. Fixes tests accordingly for the JS-SDK

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Adds error handling capability.

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

Notes

@Musilah Musilah marked this pull request as ready for review October 23, 2023 08:46
Musilah added 5 commits March 22, 2024 18:27
Signed-off-by: Musilah <nataleigh.nk@gmail.co>
Signed-off-by: Musilah <nataleigh.nk@gmail.co>
Signed-off-by: Musilah <nataleigh.nk@gmail.co>
Signed-off-by: Musilah <nataleigh.nk@gmail.co>
Signed-off-by: Musilah <nataleigh.nk@gmail.co>
@Musilah Musilah force-pushed the JSSDK-errorhandling branch from 99c9f0a to 5d57157 Compare March 22, 2024 15:48
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 1041159 into absmach:main Mar 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants