Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(apis_entities): merge link broken #1278

Closed
gythaogg opened this issue Oct 10, 2024 · 0 comments · Fixed by #1283 or #1264
Closed

bug(apis_entities): merge link broken #1278

gythaogg opened this issue Oct 10, 2024 · 0 comments · Fixed by #1283 or #1264
Assignees
@gythaogg
Labels
bug Something isn't working (properly, as expected, at all)

Comments

@gythaogg
Copy link
Contributor

gythaogg commented Oct 10, 2024 •
edited
Loading

Steps to reproduce:

  1. Go to any entity detail page (Example: https://discworld.acdh-ch-dev.oeaw.ac.at/sample_project.person/1)
  2. Click on Actions and then Merge in the Actions menu

Expected behaviour: A form to select to the entity with which this entity needs to be merged
Actual behaviour: The page reloads.

I think this was introduced in ba7ad4c when get_merge_url was removed from apis_entities.models which used return generic_entities_merge_view

The get_merge_url in generic/abc.py (introduced in 5f21c4d) instead returns apis_core:generic:merge which shouldn't be called on clicking the Merge link

@b1rger: It might make sense to remove Merge from this Action menu and use the Merge field in the Edit view below the Relations table
@gythaogg gythaogg added the bug Something isn't working (properly, as expected, at all) label Oct 10, 2024
@gythaogg gythaogg mentioned this issue Oct 11, 2024
Closed
gythaogg added a commit that referenced this issue Oct 11, 2024
@gythaogg
fix(apis_entities): correct merge link
c8cc6cb 
The merge link was incorrectly pointing the merge action view that
merges two objects; it has been corrected to point to the merge view
that allows the user to select another object for merging.

closes #1278
@gythaogg gythaogg mentioned this issue Oct 11, 2024
Merged
@gythaogg gythaogg added the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Oct 11, 2024
@gythaogg gythaogg mentioned this issue Oct 11, 2024
Closed
@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Oct 15, 2024
b1rger pushed a commit that referenced this issue Oct 15, 2024
@gythaogg @b1rger
fix(apis_entities): correct merge link
1ca682c 
The merge link was incorrectly pointing the merge action view that
merges two objects; it has been corrected to point to the merge view
that allows the user to select another object for merging.

closes #1278
b1rger pushed a commit that referenced this issue Oct 15, 2024
@gythaogg @b1rger
fix(apis_entities): correct merge link
0088fc6 
The merge link was incorrectly pointing the merge action view that
merges two objects; it has been corrected to point to the merge view
that allows the user to select another object for merging.

closes #1278
@github-actions github-actions bot mentioned this issue Oct 15, 2024
Merged
@github-actions github-actions bot mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gythaogg gythaogg

Labels
bug Something isn't working (properly, as expected, at all)
Projects
None yet
Milestone
No milestone
3 participants
@sennierer @b1rger @gythaogg