Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relations): use javascript onclick instead of htmx on:click #1270

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Oct 7, 2024

This makes the trigger also work with a strict CSP that does not allow
unsafe-eval.

Closes: #1265

This makes the trigger also work with a strict CSP that does not allow
`unsafe-eval`.

Closes: #1265
@b1rger b1rger marked this pull request as ready for review October 7, 2024 09:32
@b1rger b1rger requested a review from gythaogg October 7, 2024 09:35
@gythaogg
Copy link
Contributor

gythaogg commented Oct 7, 2024

Not able to test my ontology with 429cee5 due to an unrelated error - see below. It didn't come up in release 0.28.0, so I applied your change to list_relations template locally and it works. The dialog appears with a thick black border but I guess we can sort that out with styles. Thanks a lot @b1rger

  File "~/.cache/pypoetry/virtualenvs/nomansland-dev-6zat2Y40-py3.11/lib/python3.11/site-packages/apis_core/collections/models.py", line 23, in <module>
    class SkosCollection(GenericModel, models.Model):
  File "~/.cache/pypoetry/virtualenvs/nomansland-dev-6zat2Y40-py3.11/lib/python3.11/site-packages/apis_core/collections/models.py", line 35, in SkosCollection
    class Meta:
  File "~/.cache/pypoetry/virtualenvs/nomansland-dev-6zat2Y40-py3.11/lib/python3.11/site-packages/apis_core/collections/models.py", line 38, in Meta
    models.UniqueConstraint(
TypeError: UniqueConstraint.__init__() got an unexpected keyword argument 'nulls_distinct'

@b1rger
Copy link
Contributor Author

b1rger commented Oct 7, 2024

Could you try with Django 5?

@gythaogg
Copy link
Contributor

gythaogg commented Oct 7, 2024

Could you try with Django 5?

Constrained because

apis-highlighter-ng (0.3.1) depends on Django (>=4.1,<5.0), 
apis-highlighter-ng (>=0.3.1,<0.3.2 || >0.3.2,<0.4.0) requires Django (>=4.1,<5.0).

Updated my comment - I went back to release 28 and applied this change alone; it works!

Copy link
Contributor

@gythaogg gythaogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you!

@b1rger b1rger merged commit db2b008 into main Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create new relations
2 participants