Fix convertJs export #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,5 +22,6 @@ function jsonSass(options) { | |||
| } | |||
|
|
|||
| module.exports = jsonSass; | |||
| module.exports.convertJs = jsToSassString; | |||
| export default jsonSass; | |||
| export { jsToSassString as convertJs }; | |||
There was a problem hiding this comment.
this line should be exporting it, I believe. I wonder if line 24 is causing isses with it. Babel handles translating ES6 module syntax to requirejs.
There was a problem hiding this comment.
Looks like it's an issue with how babel exports things with only a default or with a default and other properties: http://babeljs.io/docs/usage/modules/#interop
(Or not quite an issue, it's by design). Anyway, I have a different fix for it in #9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5