Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convertJs export #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix convertJs export #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/jsonSass.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ function jsonSass(options) {
}

module.exports = jsonSass;
module.exports.convertJs = jsToSassString;
export default jsonSass;
export { jsToSassString as convertJs };
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be exporting it, I believe. I wonder if line 24 is causing isses with it. Babel handles translating ES6 module syntax to requirejs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's an issue with how babel exports things with only a default or with a default and other properties: http://babeljs.io/docs/usage/modules/#interop
(Or not quite an issue, it's by design). Anyway, I have a different fix for it in #9.