-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-1192: Symfony 6.3.4 breaks checklists #1766
Conversation
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1766/acli.phar
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1766 +/- ##
=========================================
Coverage 91.99% 91.99%
Complexity 1818 1818
=========================================
Files 121 121
Lines 6834 6834
=========================================
Hits 6287 6287
Misses 547 547 ☔ View full report in Codecov by Sentry. |
@anavarre do commands with checklists still look good to you with this? It's a finicky change, I need someone with a strong eye for detail... |
@danepowell I tried a few commands in an IDE and it does look good to me. First one:
Second one:
|
Motivation
Fixes #1620
Proposed changes
Alternatives considered
Testing steps
./bin/acli ckc