Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1192: Symfony 6.3.4 breaks checklists #1766

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes #1620

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell danepowell added the bug Something isn't working label Jul 10, 2024
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1766/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1766/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (6fbaaa3) to head (7cf4b4d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1766   +/-   ##
=========================================
  Coverage     91.99%   91.99%           
  Complexity     1818     1818           
=========================================
  Files           121      121           
  Lines          6834     6834           
=========================================
  Hits           6287     6287           
  Misses          547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell
Copy link
Contributor Author

@anavarre do commands with checklists still look good to you with this? It's a finicky change, I need someone with a strong eye for detail...

@anavarre
Copy link
Contributor

@danepowell I tried a few commands in an IDE and it does look good to me.

First one:

checklist:~/project $ /tmp/acli.phar pull
Cloning into current directory.
Using Cloud Application REDACTEDd8

 Choose a Cloud Platform environment [Dev, dev (vcs: tags/WELCOME)]:
  [0] Dev, dev (vcs: tags/WELCOME)
  [1] Prod, prod (vcs: tags/WELCOME)
  [2] Stage, test (vcs: tags/WELCOME)
 > 0

    ✔ Cloning git repository from the Cloud Platform
    ⌛ Copying Drupal's public files from the Cloud Platform...
 
 ! [NOTE] This is a multisite application. Drupal will load the default site unless you've configured sites.php for this
 !        environment: https://docs.acquia.com/cloud-platform/develop/drupal/multisite/                                 

    ✔ Waiting for the key to become available in Cloud Platform git environments
    ✔ Waiting for the key to become available in Cloud Platform nonprod environments
    ✔ Waiting for the key to become available in Cloud Platform prod environments

Your SSH key is ready for use!

Second one:

checklist:~/project ((WELCOME)) $ mkdir /tmp/artifact && /tmp/acli.phar archive:export --no-database /tmp/artifact

 This will generate a new archive in /tmp/artifact containing the contents of your Drupal application at /home/ide/project.
 Do you want to continue? (yes/no) [yes]:
 > yes

    ✔ Removing temporary artifact directory
    ✔ Generating temporary archive directory
    ✔ Compressing archive into a tarball

                                                                                                                        
 [OK] An archive of your Drupal application was created at /tmp/artifact/acli-archive-project-1720697726-57690.tar.gz   
                                                                                                                        

 ! [NOTE] You can download the archive through the Cloud IDE user interface by right-clicking the file in your IDE      
 !        workspace file browser and selecting "Download." 

@danepowell danepowell enabled auto-merge (squash) July 11, 2024 20:32
@danepowell danepowell merged commit 153d33c into acquia:main Jul 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-1192: Symfony 6.3.4 breaks checklists
2 participants