Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu] Added firefox to Ubuntu24.04 image #10553

Closed
wants to merge 3 commits into from

Conversation

ijunaidm
Copy link
Contributor

@ijunaidm ijunaidm commented Sep 4, 2024

Description

Added Firefox to Ubuntu24.04 image.

Related issue:

#10374

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@ijunaidm ijunaidm self-assigned this Sep 4, 2024
maxim-lobanov
maxim-lobanov previously approved these changes Sep 4, 2024
@erik-bershel erik-bershel changed the title Added firefox to Ubuntu24.04 image [Ubuntu] Added firefox to Ubuntu24.04 image Sep 4, 2024
It "Firefox" {
"firefox --version" | Should -ReturnZeroExitCode
}

It "Geckodriver" {
"geckodriver --version" | Should -ReturnZeroExitCode
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pester test structure is broken. The Describe section should be surrounded by { } characters.
e.g.

Describe "pack of tests" {
    It "sometest" {
        ... some code ...
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants