Update C api #491
Merged
Update C api #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementors should prefer to call `ada_set_pathname('')` instead of `ada_clear_pathname`
lemire
reviewed
Aug 29, 2023
| @@ -87,7 +87,6 @@ void ada_set_hash(ada_url result, const char* input, size_t length); | |||
| // url_aggregator clear methods | |||
| void ada_clear_port(ada_url result); | |||
| void ada_clear_hash(ada_url result); | |||
| void ada_clear_pathname(ada_url result); | |||
There was a problem hiding this comment.
ada_clear_pathname can be implemented as set_pathname(""). I think.
There was a problem hiding this comment.
Yes, I added as a commit comment but I don't think we need another function for this.
lemire
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
ada_clear_pathnamebecause it is not feasible to make this public.Fixes #490