Update C api

fuzz/parse.cc

@@ -79,7 +79,6 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
 
     // clear methods
     out_aggregator->clear_port();
-    out_aggregator->clear_pathname();
     out_aggregator->clear_search();
     out_aggregator->clear_hash();
   }

include/ada/url_aggregator.h

@@ -198,7 +198,6 @@ struct url_aggregator : url_base {
 
   inline void clear_port();
   inline void clear_hash();
-  inline void clear_pathname() override;
   inline void clear_search() override;
 
  private:
@@ -277,6 +276,7 @@ struct url_aggregator : url_base {
   inline uint32_t retrieve_base_port() const;
   inline void clear_hostname();
   inline void clear_password();
+  inline void clear_pathname() override;
   inline bool has_dash_dot() const noexcept;
   void delete_dash_dot();
   inline void consume_prepared_path(std::string_view input);

include/ada_c.h

@@ -87,7 +87,6 @@ void ada_set_hash(ada_url result, const char* input, size_t length);
 // url_aggregator clear methods
 void ada_clear_port(ada_url result);
 void ada_clear_hash(ada_url result);
-void ada_clear_pathname(ada_url result);
 void ada_clear_search(ada_url result);
 
 // url_aggregator functions

src/ada_c.cpp

@@ -287,13 +287,27 @@ bool ada_set_pathname(ada_url result, const char* input,
   return r->set_pathname(std::string_view(input, length));
 }
 
+/**
+ * Update the search/query of the URL.
+ *
+ * If a URL has `?` as the search value, passing empty string to this function
+ * does not remove the attribute. If you need to remove it, please use
+ * `ada_clear_search` method.
+ */
 void ada_set_search(ada_url result, const char* input, size_t length) noexcept {
   ada::result<ada::url_aggregator>& r = get_instance(result);
   if (r) {
     r->set_search(std::string_view(input, length));
   }
 }
 
+/**
+ * Update the hash/fragment of the URL.
+ *
+ * If a URL has `#` as the hash value, passing empty string to this function
+ * does not remove the attribute. If you need to remove it, please use
+ * `ada_clear_hash` method.
+ */
 void ada_set_hash(ada_url result, const char* input, size_t length) noexcept {
   ada::result<ada::url_aggregator>& r = get_instance(result);
   if (r) {
@@ -308,20 +322,25 @@ void ada_clear_port(ada_url result) noexcept {
   }
 }
 
+/**
+ * Removes the hash of the URL.
+ *
+ * Despite `ada_set_hash` method, this function allows the complete
+ * removal of the hash attribute, even if it has a value of `#`.
+ */
 void ada_clear_hash(ada_url result) noexcept {
   ada::result<ada::url_aggregator>& r = get_instance(result);
   if (r) {
     r->clear_hash();
   }
 }
 
-void ada_clear_pathname(ada_url result) noexcept {
-  ada::result<ada::url_aggregator>& r = get_instance(result);
-  if (r) {
-    r->clear_pathname();
-  }
-}
-
+/**
+ * Removes the search of the URL.
+ *
+ * Despite `ada_set_search` method, this function allows the complete
+ * removal of the search attribute, even if it has a value of `?`.
+ */
 void ada_clear_search(ada_url result) noexcept {
   ada::result<ada::url_aggregator>& r = get_instance(result);
   if (r) {

tests/ada_c.cpp

@@ -104,8 +104,6 @@ TEST(ada_c, setters) {
 
   ada_set_pathname(url, "new-pathname", strlen("new-pathname"));
   ASSERT_EQ(convert_string(ada_get_pathname(url)), "/new-pathname");
-  ada_clear_pathname(url);
-  ASSERT_EQ(convert_string(ada_get_pathname(url)), "");
 
   ada_set_search(url, "new-search", strlen("new-search"));
   ASSERT_EQ(convert_string(ada_get_search(url)), "?new-search");
@@ -179,3 +177,35 @@ TEST(ada_c, ada_idna) {
   ada_free_owned_string(unicode);
   SUCCEED();
 }
+
+TEST(ada_c, ada_clear_hash) {
+  // Make sure a hash attribute with `#` is removed.
+  std::string_view input = "https://www.google.com/hello-world?query=1#";
+  ada_url out = ada_parse(input.data(), input.size());
+  ASSERT_TRUE(ada_is_valid(out));
+
+  ada_clear_hash(out);
+  ASSERT_EQ(convert_string(ada_get_hash(out)), "");
+  ASSERT_FALSE(ada_has_hash(out));
+  ASSERT_EQ(convert_string(ada_get_href(out)),
+            "https://www.google.com/hello-world?query=1");
+
+  ada_free(out);
+  SUCCEED();
+}
+
+TEST(ada_c, ada_clear_search) {
+  // Make sure a search attribute with `?` is removed.
+  std::string_view input = "https://www.google.com/hello-world?#hash";
+  ada_url out = ada_parse(input.data(), input.size());
+  ASSERT_TRUE(ada_is_valid(out));
+
+  ada_clear_search(out);
+  ASSERT_EQ(convert_string(ada_get_search(out)), "");
+  ASSERT_FALSE(ada_has_search(out));
+  ASSERT_EQ(convert_string(ada_get_href(out)),
+            "https://www.google.com/hello-world#hash");
+
+  ada_free(out);
+  SUCCEED();
+}