-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework) Add flwr login protos #4244
Open
danielnugraha
wants to merge
10
commits into
main
Choose a base branch
from
add-flwr-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+223
−3
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d103055
Add Login RPC
danielnugraha 3bbc214
Generate updated proto
danielnugraha f7f06aa
Add login servicer
danielnugraha da31e25
Format
danielnugraha 211bc3a
Format
danielnugraha 5ff2e9e
Update proto definition
danielnugraha 7fe6a39
Format
danielnugraha f8d6b2c
Format
danielnugraha 158677f
Format
danielnugraha 8e874a4
Format
danielnugraha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,11 @@ service Exec { | |
|
||
// flwr ls command | ||
rpc ListRuns(ListRunsRequest) returns (ListRunsResponse) {} | ||
|
||
// Start login upon request | ||
rpc Login(LoginRequest) returns (LoginResponse) {} | ||
|
||
rpc GetAuthToken(GetAuthTokenRequest) returns (GetAuthTokenResponse) {} | ||
} | ||
|
||
message StartRunRequest { | ||
|
@@ -52,3 +57,9 @@ message ListRunsResponse { | |
map<uint64, Run> run_dict = 1; | ||
string now = 2; | ||
} | ||
|
||
message LoginRequest {} | ||
message LoginResponse { map<string, string> login_details = 1; } | ||
|
||
message GetAuthTokenRequest { map<string, string> auth_details = 1; } | ||
message GetAuthTokenResponse { map<string, string> auth_tokens = 1; } | ||
Comment on lines
+64
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we list out the login details needed, instead of using a dictionary? Just to make it clear.