Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition missing for Service 'adempiere.report.engine' #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcalwestf
Copy link
Contributor

@marcalwestf marcalwestf commented Jul 19, 2024

Fixes #116

With the changes, it is now possible to run the project with script start-all.sh using the service files.

@EdwinBetanc0urt Edwin, it maybe of interest to you.

…mpose service file 10c-grpc_proxy_service_standard.yml
@marcalwestf marcalwestf requested a review from yamelsenih July 19, 2024 16:34
@marcalwestf marcalwestf self-assigned this Jul 19, 2024
@marcalwestf marcalwestf added the bug Something isn't working label Jul 19, 2024
@EdwinBetanc0urt
Copy link
Contributor

Hi @marcalwestf Mario, it has not yet been placed to the standard because this service is under development, however having it there does not affect the current operation until the changes of vue in the report-engine branch are integrated to the main branch that would make use of those end-points of the report-engine service.

@EdwinBetanc0urt
Copy link
Contributor

I think the report engine grpc service should be separated in another .yml file, as is the processors grpc and the vue backend grpc.

@marcalwestf
Copy link
Contributor Author

@EdwinBetanc0urt as you suggested, I implemented the service adempiere.report.engine as a separate file.

In order to preserve the file sequence and to keep the script file start-all.sh readable, I renamed the files following the report engine service.

I executed a docker compose dry run for standard stack legacy and non-legacy and the results were as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition missing for Service 'adempiere.report.engine'
2 participants