Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add events to gaze integration functions #554

Merged
merged 16 commits into from
Sep 15, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Sep 14, 2023

Description

Add newly added events keyword argument to GazeDataFrame.__init__().

Depends on #552 and #553

Implemented changes

  • Added events to gaze.from_numpy()
  • Added events to gaze.from_pandas()

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added basic test cases for from_numpy()
  • Added basic test cases for from_pandas()

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (097cbbb) 100.00% compared to head (c7c9186) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2139      2145    +6     
  Branches       521       522    +1     
=========================================
+ Hits          2139      2145    +6     
Files Changed Coverage Δ
src/pymovements/__init__.py 100.00% <100.00%> (ø)
src/pymovements/events/processing.py 100.00% <100.00%> (ø)
src/pymovements/gaze/gaze_dataframe.py 100.00% <100.00%> (ø)
src/pymovements/gaze/integration.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako force-pushed the feature/gaze-integration-events branch 2 times, most recently from 09e3539 to 76831fb Compare September 14, 2023 09:59
@dkrako dkrako force-pushed the feature/gaze-integration-events branch from 9de020f to 24de5e2 Compare September 14, 2023 11:31
@dkrako dkrako marked this pull request as ready for review September 14, 2023 12:20
@dkrako dkrako mentioned this pull request Sep 14, 2023
16 tasks
@dkrako dkrako merged commit 88af8d0 into main Sep 15, 2023
@dkrako dkrako deleted the feature/gaze-integration-events branch September 15, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants