Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: drop support for python 3.8 #572

Merged
merged 6 commits into from
Sep 26, 2023
Merged

build: drop support for python 3.8 #572

merged 6 commits into from
Sep 26, 2023

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Sep 22, 2023

would resolve #571

@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1b5c285) 100.00% compared to head (0664602) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #572   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         2237      2234    -3     
  Branches       552       552           
=========================================
- Hits          2237      2234    -3
Files Coverage Δ
src/pymovements/dataset/dataset_library.py 100.00% <100.00%> (ø)
src/pymovements/gaze/transforms.py 100.00% <100.00%> (ø)
src/pymovements/plotting/traceplot.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkrako
dkrako approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@dkrako dkrako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully approve!

@dkrako dkrako changed the title drop python 3.8 build: drop support for python 3.8 Sep 22, 2023
@SiQube SiQube mentioned this pull request Sep 22, 2023
Merged
@SiQube SiQube enabled auto-merge (squash) September 26, 2023 16:43
@SiQube
Copy link
Member Author

SiQube commented Sep 26, 2023 •
edited
Loading

if merged we can also implement the changes requested here. in PR #563

@SiQube SiQube merged commit 8f0b7c6 into main Sep 26, 2023
@SiQube SiQube deleted the drop-python-38 branch September 26, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrako dkrako dkrako approved these changes

@prassepaul prassepaul Awaiting requested review from prassepaul prassepaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop python 3.8
2 participants
@SiQube @dkrako