-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Custom patterns for parsing logged metadata in ASC files #767
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 3230 3225 -5
Branches 925 925
=========================================
- Hits 3230 3225 -5 ☔ View full report in Codecov by Sentry. |
NOTE: #510 says:
So not sure if this breaking interface change in |
for more information, see https://pre-commit.ci
536158e
to
5890edf
Compare
I think this is a great addition and the benefits outweigh the breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good -- some minor comments
@prassepaul @dkrako I'd liked to have a second pair of eyes on this breaking change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Return metadata from from_asc() * Parse metadata from ASC files based on custom patterns * Refactor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor * Fix test coverage * Fix docstrings * Fix docstring --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David R. Reich <[email protected]>
Description
Fixes #758
Implemented changes
from_asc()
matadata_patterns
tofrom_asc()
andparse_eyelink()
None
for metadata keys specified inmetadata_patterns
that are not present in the ASC fileTODO
Type of change
How Has This Been Tested?
None
valuesChecklist: