Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ refactor ] Add Data.Bool.ListAction #2561

Merged
merged 8 commits into from
Feb 5, 2025
Merged

[ refactor ] Add Data.Bool.ListAction #2561

merged 8 commits into from
Feb 5, 2025

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jan 22, 2025 •
edited
Loading

This is the Bool analogue of #2558; see discussion there and on #2553 .

Issue:

  • intended as a v2.3 compatibility stub module, ahead of a more thorough refactoring in terms of Data.List.Effectful.Foldable.foldMap?

@jamesmckinna jamesmckinna added this to the v2.3 milestone Jan 22, 2025
@jamesmckinna jamesmckinna mentioned this pull request Jan 22, 2025
Open
@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Jan 22, 2025 •
edited
Loading

Aaargh! Once again, the deprecations warnings are only biting when the HTML indexing phase takes place, so these errors aren't turning up locally when I run make test (er, they are, in fact, I'm just to impatient to notice :-(). Will try to do a more thorough search for the knock-ons... sigh.

JacquesCarette
JacquesCarette approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that none of those functions have properties in the library!

@jamesmckinna
Copy link
Contributor Author

Surprised that none of those functions have properties in the library!

Well, I think that once each of all and any are shown equivalent (via T) to their corresponding Relation.Unary predicate forms All and Any, perhaps they don't need to?

@jamesmckinna jamesmckinna changed the title [ refactor ] Bool analogue of #2558 [ refactor ] Add Data.Bool.ListAction Jan 24, 2025
This was referenced Jan 21, 2025
Open
Draft
@jamesmckinna
Copy link
Contributor Author

Propose merging this now? What about (the rather more invasive, but still 'harmless') #2558 ?

@jamesmckinna jamesmckinna added this pull request to the merge queue Feb 5, 2025
Merged via the queue into agda:master with commit 31d59e4 Feb 5, 2025
2 checks passed
@jamesmckinna jamesmckinna deleted the issue2553-bool branch February 5, 2025 13:04
@jamesmckinna jamesmckinna mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette approved these changes

@gallais gallais gallais approved these changes

@Taneb Taneb Awaiting requested review from Taneb

Assignees
No one assigned
Labels
addition refactoring
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesmckinna @gallais @JacquesCarette