Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

132 example data and scripts not unified #139

Merged
merged 19 commits into from
Feb 28, 2024

Conversation

MedericFourmy
Copy link
Collaborator

@MedericFourmy MedericFourmy commented Feb 21, 2024

  • Refactor inference example scripts and cosy/megapose tests
  • Deprecate crackers example in favor of barbecue-sauce

@MedericFourmy MedericFourmy linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 20.27335% with 350 lines in your changes are missing coverage. Please review.

Project coverage is 24.92%. Comparing base (67d74ce) to head (eb0b8d0).

❗ Current head eb0b8d0 differs from pull request most recent head 902416e. Consider uploading reports for the commit 902416e to get more accurate results

Files Patch % Lines
...stimators/cosypose/cosypose/training/evaluation.py 0.00% 141 Missing ⚠️
...ypose/toolbox/inference/example_inference_utils.py 38.63% 54 Missing ⚠️
...ypose/cosypose/scripts/run_inference_on_example.py 0.00% 42 Missing ⚠️
...ators/megapose/scripts/run_inference_on_example.py 0.00% 42 Missing ⚠️
...mators/cosypose/cosypose/utils/cosypose_wrapper.py 0.00% 23 Missing ⚠️
...osypose/cosypose/scripts/convert_models_to_urdf.py 0.00% 10 Missing ⚠️
...stimators/cosypose/cosypose/training/train_pose.py 0.00% 6 Missing ⚠️
...ors/cosypose/cosypose/lib3d/rigid_mesh_database.py 0.00% 5 Missing ⚠️
.../cosypose/cosypose/datasets/bop_object_datasets.py 33.33% 4 Missing ⚠️
happypose/toolbox/inference/types.py 33.33% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
+ Coverage   24.48%   24.92%   +0.44%     
==========================================
  Files         211      214       +3     
  Lines       17650    17728      +78     
==========================================
+ Hits         4321     4419      +98     
+ Misses      13329    13309      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nim65s
Copy link
Collaborator

nim65s commented Feb 21, 2024

@codecov: you're making this review super hard, while not being super useful…

@nim65s nim65s merged commit ebea66c into dev Feb 28, 2024
10 of 13 checks passed
@nim65s nim65s deleted the 132-example-data-and-scripts-not-unified branch February 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example data and scripts not unified
2 participants