-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROI and binning handling #16
Conversation
@@ -74,43 +88,24 @@ def __init__( | |||
# Register callback depending on the configuration | |||
self._image_approx_time_sync.registerCallback(self._on_image_data_cb) | |||
|
|||
def image_guarded(func: Callable[..., RetType]) -> Callable[..., RetType]: | |||
"""Decorator, checks if image was already received. | |||
def data_recieved_guarded(func: Callable[..., RetType]) -> Callable[..., RetType]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"data_received_guarded"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually lots of "recieved" in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -5,10 +5,12 @@ | |||
|
|||
from rclpy.node import Node | |||
from rclpy.time import Time | |||
from rclpy.qos import qos_profile_sensor_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment or link explaining what qos_profile_sensor_data is meant to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was addressed in #17. This change was followed with some other networking changes in that PR
Requires #17 to be merged. Afterwards, it will be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.