Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROI and binning handling #16

Merged
merged 15 commits into from
Nov 4, 2024
Merged

Add ROI and binning handling #16

merged 15 commits into from
Nov 4, 2024

Conversation

Kotochleb
Copy link
Collaborator

No description provided.

@@ -74,43 +88,24 @@ def __init__(
# Register callback depending on the configuration
self._image_approx_time_sync.registerCallback(self._on_image_data_cb)

def image_guarded(func: Callable[..., RetType]) -> Callable[..., RetType]:
"""Decorator, checks if image was already received.
def data_recieved_guarded(func: Callable[..., RetType]) -> Callable[..., RetType]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"data_received_guarded"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually lots of "recieved" in the code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -5,10 +5,12 @@

from rclpy.node import Node
from rclpy.time import Time
from rclpy.qos import qos_profile_sensor_data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment or link explaining what qos_profile_sensor_data is meant to be

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was addressed in #17. This change was followed with some other networking changes in that PR

@Kotochleb
Copy link
Collaborator Author

Requires #17 to be merged. Afterwards, it will be ready for review

@Kotochleb Kotochleb marked this pull request as ready for review October 30, 2024 17:54
Copy link
Contributor

@MedericFourmy MedericFourmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kotochleb Kotochleb merged commit 4401f73 into main Nov 4, 2024
2 checks passed
@Kotochleb Kotochleb deleted the feature/image-cropping branch November 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants