Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise ComponentInterface by moving implementations to source file #39

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Revise ComponentInterface by moving implementations to source file #39

merged 6 commits into from
Jul 18, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jul 17, 2023 •
edited
Loading

Description

This PR should conclude the ComponentInterface refactor by

  1. moving as much code as possible to the source file since the class is not templated anymore
  2. revise the order of the methods for more clarity
  3. carefully check if the methods should be private or protected
  4. optimize the includes

This PR does not contain any changes in the logic itself, just moving around things.

Review guidelines

Estimated Time of Review: 10 minutes

@domire8 domire8 requested a review from eeberhard July 17, 2023 06:55
@domire8 domire8 linked an issue Jul 17, 2023 that may be closed by this pull request
Use node interfaces in ros:iron to avoid templated ComponentInterface #32
Closed
eeberhard
eeberhard approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, nice work 👍

@domire8 domire8 merged commit 2f0133f into iron-component-interface Jul 18, 2023
@domire8 domire8 deleted the refactor/move-to-source branch July 18, 2023 05:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eeberhard eeberhard eeberhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use node interfaces in ros:iron to avoid templated ComponentInterface
2 participants
@domire8 @eeberhard