WIP: Build on arm64

.github/workflows/build.yml

@@ -2,8 +2,6 @@
 name: Build images and upload them to ghcr.io
 
 env:
-    OWNER: ${{ github.repository_owner }}
-    REGISTRY: ghcr.io
     BUILDKIT_PROGRESS: plain
     # https://github.com/docker/metadata-action?tab=readme-ov-file#environment-variables
     DOCKER_METADATA_PR_HEAD_SHA: true
@@ -22,7 +20,7 @@ on:
 
 jobs:
     build:
-        name: amd64 & arm64
+        name: build
         runs-on: ${{ inputs.runsOn }}
         timeout-minutes: 120
 
@@ -39,98 +37,37 @@ jobs:
             - name: Checkout Repo ⚡️
               uses: actions/checkout@v4
 
-            - name: Set up QEMU
-              uses: docker/setup-qemu-action@v3
-
             - name: Set up Docker Buildx
               uses: docker/setup-buildx-action@v3
 
             - name: Login to GitHub Container Registry 🔑
               uses: docker/login-action@v3
               with:
-                  registry: ${{ env.REGISTRY }}
+                  registry: ghcr.io
                   username: ${{ github.actor }}
                   password: ${{ secrets.GITHUB_TOKEN }}
 
-            - name: Generate tags for images on ghcr.io 🏷️
-              id: tags_template
-              uses: docker/metadata-action@v5
-              with:
-                  bake-target: __template__-meta
-                  images: |
-                      name=${{ env.REGISTRY }}/aiidalab/__template__
-                  tags: |
-                      type=ref,event=pr
-                      type=edge,branch=main
-                      type=raw,value={{tag}},enable=${{ github.ref_type == 'tag' && ! startsWith(github.ref_name, 'v') }}
-                      type=raw,value=aiida-${{ env.AIIDA_VERSION }},enable=${{ github.ref_type == 'tag'  && startsWith(github.ref_name, 'v') }}
-                      type=raw,value=python-${{ env.PYTHON_VERSION }},enable=${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'v') }}
-                      type=raw,value=postgresql-${{ env.PGSQL_VERSION }},enable=${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'v') }}
-                      type=match,pattern=v(\d{4}\.\d{4}(-.+)?),group=1
-
-            - name: Generate docker-bake metadata file.
-              env:
-                  BAKE_TEMPLATE_FILE: ${{ steps.tags_template.outputs.bake-file }}
-              run: |
-                  .github/workflows/merge-bake-template-target.sh ${BAKE_TEMPLATE_FILE} \
-                    | tee docker-bake-template-meta.json
-
-            - name: Build amd64 images 🏗️
-              id: build-amd64
+              # https://docs.docker.com/build/ci/github-actions/multi-platform/#with-bake
+            - name: Build untagged images and push to ghcr.io 🏗️
+              id: build
               uses: docker/bake-action@v4
               with:
-                  push: true
-                  set: |
-                      *.platform=linux/amd64
-                  files: |
-                      docker-bake.hcl
-                      build.json
-                      docker-bake-template-meta.json
-
-            - name: Get amd64 images with digests
-              id: bake_metadata_amd64
-              env:
-                  BAKE_METADATA: ${{ steps.build-amd64.outputs.metadata }}
-              run: |
-                  .github/workflows/extract-image-names.sh >> "${GITHUB_OUTPUT}"
-
-            - name: Set Up Python 🐍
-              if: ${{ inputs.runner != 'ARM64' }}
-              uses: actions/setup-python@v5
-              with:
-                  python-version: '3.11'
-                  cache: pip
-
-            - name: Install dependencies 📦
-              run: |
-                  pip install -r requirements.txt
-                  pip freeze
-
-              # We run tests here to catch issues early, before running arm64 build which is slow
-            - name: Run tests for full-stack image
-              run: REGISTRY= pytest -m "not integration" --target full-stack
-              env: ${{ fromJSON(steps.bake_metadata_amd64.outputs.images) }}
-
-              # Here we build arm64 images (with help of QEMU virtualization)
-              # and upload both amd64 and arm64 images to ghcr.io
-            - name: Build ARM64 and upload to ghcr.io 🍎📤
-              id: build-upload
-              uses: docker/bake-action@v4
-              with:
-                  push: true
                   # Using provenance to disable default attestation so it will build only desired images:
                   # https://github.com/orgs/community/discussions/45969
                   provenance: false
-                  # NOTE: linux/amd64 images are taken from previous step
+                  push: true
                   set: |
-                      *.platform=linux/amd64,linux/arm64
+                      *.platform=linux/${{ startsWith(inputs.runsOn, 'ubuntu') && 'amd64' || 'arm64' }}
+                      *.output=type=registry,push-by-digest=true,name-canonical=true
                   files: |
                       docker-bake.hcl
                       build.json
-                      docker-bake-template-meta.json
+                      .github/workflows/env.hcl
 
-            - name: Set output variables
+            - name: Get image names with digests
               id: bake_metadata
-              run: .github/workflows/extract-image-names.sh >> "${GITHUB_OUTPUT}"
+              run: |
+                  .github/workflows/extract-image-names.sh
+                  .github/workflows/extract-image-names.sh >> "${GITHUB_OUTPUT}"
               env:
-                  BAKE_METADATA: ${{ steps.build-upload.outputs.metadata }}
+                  BAKE_METADATA: ${{ steps.build.outputs.metadata }}

.github/workflows/env.hcl

@@ -0,0 +1,2 @@
+# env.hcl
+REGISTRY = "ghcr.io/"

.github/workflows/extract-image-names.sh

@@ -7,10 +7,10 @@ set -euo pipefail
 
 # The input to this script is a JSON string passed via BAKE_METADATA env variable
 # Here's example input (trimmed to relevant bits):
-# BAKE_META: {
+# BAKE_METADATA: {
 #    "base": {
+#        "base": {
 #      "buildx.build.ref": "builder-9dc30f03-42f5-4fd5-8c9a-0d54be5ad996/builder-9dc30f03-42f5-4fd5-8c9a-0d54be5ad9960/jex1w6zvslbbomtkedn4no62l",
-#      "containerimage.config.digest": "sha256:b76dc61672dd0efbd586d56393d3a57f6309654e6903d738168892bc09017e8b",
 #      "containerimage.descriptor": {
 #        "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
 #        "digest": "sha256:8e57a52b924b67567314b8ed3c968859cad99ea13521e60bbef40457e16f391d",
@@ -21,29 +21,32 @@ set -euo pipefail
 #        }
 #      },
 #      "containerimage.digest": "sha256:8e57a52b924b67567314b8ed3c968859cad99ea13521e60bbef40457e16f391d",
-#      "image.name": "ghcr.io/aiidalab/base:pr-439,ghcr.io/aiidalab/base:sha-a0cd2be"
+#      "image.name": "ghcr.io/aiidalab/base"
 #    },
 #    "base-with-services": {
-#       "containerimage.digest": "sha256:6753a809b5b2675bf4c22408e07c1df155907a465b33c369ef93ebcb1c4fec26",
-#       "...": ""
+#      "image.name": "ghcr.io/aiidalab/base-with-services"
+#      "containerimage.digest": "sha256:6753a809b5b2675bf4c22408e07c1df155907a465b33c369ef93ebcb1c4fec26",
+#      "...": ""
 #    }
 #    "full-stack": {
-#       "containerimage.digest": "sha256:85ee91f61be1ea601591c785db038e5899d68d5fb89e07d66d9efbe8f352ee48",
-#       "...": ""
+#      "image.name": "ghcr.io/aiidalab/full-stack"
+#      "containerimage.digest": "sha256:85ee91f61be1ea601591c785db038e5899d68d5fb89e07d66d9efbe8f352ee48",
+#      "...": ""
 #    }
 #    "lab": {
-#       "containerimage.digest": "sha256:4d9be090da287fcdf2d4658bb82f78bad791ccd15dac9af594fb8306abe47e97",
-#       "...": ""
+#      "image.name": "ghcr.io/aiidalab/lab"
+#      "containerimage.digest": "sha256:4d9be090da287fcdf2d4658bb82f78bad791ccd15dac9af594fb8306abe47e97",
+#      "...": ""
 #    }
 #  }
 #
 # Example output (real output is on one line):
 #
 # images={
-#   "BASE_IMAGE":"ghcr.io/aiidalab/base:pr-439@sha256:8e57a52b924b67567314b8ed3c968859cad99ea13521e60bbef40457e16f391d",
-#   "BASE_WITH_SERVICES_IMAGE":"ghcr.io/aiidalab/base-with-services:pr-439@sha256:6753a809b5b2675bf4c22408e07c1df155907a465b33c369ef93ebcb1c4fec26",
-#   "FULL_STACK_IMAGE":"ghcr.io/aiidalab/full-stack:pr-439@sha256:85ee91f61be1ea601591c785db038e5899d68d5fb89e07d66d9efbe8f352ee48",
-#   "LAB_IMAGE":"ghcr.io/aiidalab/lab:pr-439@sha256:4d9be090da287fcdf2d4658bb82f78bad791ccd15dac9af594fb8306abe47e97"
+#   "BASE_IMAGE":"ghcr.io/aiidalab/base@sha256:8e57a52b924b67567314b8ed3c968859cad99ea13521e60bbef40457e16f391d",
+#   "BASE_WITH_SERVICES_IMAGE":"ghcr.io/aiidalab/base-with-services@sha256:6753a809b5b2675bf4c22408e07c1df155907a465b33c369ef93ebcb1c4fec26",
+#   "FULL_STACK_IMAGE":"ghcr.io/aiidalab/full-stack@sha256:85ee91f61be1ea601591c785db038e5899d68d5fb89e07d66d9efbe8f352ee48",
+#   "LAB_IMAGE":"ghcr.io/aiidalab/lab@sha256:4d9be090da287fcdf2d4658bb82f78bad791ccd15dac9af594fb8306abe47e97"
 # }
 
 if [[ -z ${BAKE_METADATA-} ]];then

.github/workflows/main.yml

@@ -18,56 +18,80 @@ concurrency:
 
 jobs:
 
-    build:
+    build-amd64:
         uses: ./.github/workflows/build.yml
         with:
             runsOn: ubuntu-22.04
 
     test-amd64:
-        needs: build
+        needs: build-amd64
         strategy:
             fail-fast: false
             matrix:
-                # NOTE: amd64 full-stack image is tested during build step
-                target: ["base", "lab", "base-with-services"]
-
+                target: [base, full-stack] #[base, lab, base-with-services, full-stack]
         uses: ./.github/workflows/test.yml
         with:
             runsOn: ubuntu-22.04
-            images: ${{ needs.build.outputs.images }}
+            images: ${{ needs.build-amd64.outputs.images }}
             target: ${{ matrix.target }}
             integration: false
 
-    # To save self-hosted runner resources, we're only testing full-stack image
+    # To save arm64 runner resources, we only try to build once amd64 build and tests succeed
+    build-arm64:
+        needs: [build-amd64, test-amd64]
+        uses: ./.github/workflows/build.yml
+        with:
+            runsOn: buildjet-4vcpu-ubuntu-2204-arm
+
     test-arm64:
-        needs: build
+        needs: build-arm64
+        strategy:
+            fail-fast: false
+            matrix:
+                target: [base, full-stack] #[base, lab, base-with-services, full-stack]
         uses: ./.github/workflows/test.yml
         with:
-            runsOn: ARM64
-            images: ${{ needs.build.outputs.images }}
-            target: "full-stack"
+            runsOn: buildjet-2vcpu-ubuntu-2204-arm
+            images: ${{ needs.build-arm64.outputs.images }}
+            target: ${{ matrix.target }}
             integration: false
 
     test-integration:
-        needs: build
+        needs: [build-arm64, build-amd64]
         strategy:
             fail-fast: false
             matrix:
-                runner: ["ubuntu-22.04", "ARM64"]
+                runsOn: [ubuntu-22.04, ARM64]
         uses: ./.github/workflows/test.yml
         with:
-            runsOn: ${{ matrix.runner }}
-            images: ${{ needs.build.outputs.images }}
-            target: "full-stack"
+            runsOn: ${{ matrix.runsOn}}
+            images: ${{ startsWith(matrix.runsOn, 'ubuntu') && needs.build-amd64.outputs.images || needs.build-arm64.outputs.images }}
+            target: full-stack
             integration: true
 
-    publish:
+    publish_ghcr:
+        if: github.repository == 'aiidalab/aiidalab-docker-stack'
+        needs: [test-amd64, test-arm64]
+        uses: ./.github/workflows/publish_ghcr.yml
+        with:
+            runsOn: ubuntu-22.04
+            registry: ghcr.io
+            images_amd64: ${{ needs.test_amd64.inputs.images }}
+            images_arm64: ${{ needs.test_arm64.inputs.images }}
+        secrets:
+            REGISTRY_USERNAME: ${{ github.actor }}
+            REGISTRY_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+    publish_docker:
         if: >-
             github.repository == 'aiidalab/aiidalab-docker-stack'
             && (github.ref_type == 'tag' || github.ref_name == 'main')
-        needs: [build, test-amd64, test-arm64]
+        needs: [publish_ghcr]
         uses: ./.github/workflows/publish.yml
         with:
             runsOn: ubuntu-22.04
-            images: ${{ needs.build.outputs.images }}
-        secrets: inherit
+            registry: docker.io
+            images: ${{ needs.publish_ghcr.outputs.images }}
+        secrets:
+            REGISTRY_USERNAME: ${{ secrets.DOCKER_USERNAME }}
+            REGISTRY_TOKEN: ${{ secrets.DOCKER_PASSWORD }}