Issue 188 local docker dev for make #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbilskiAkam
reviewed
Jul 4, 2024
| # The purpose of this file is to simply run make commands in deterministic | ||
| # environment for those interested in contributing. This is not to be used | ||
| # for production purposes. | ||
| FROM ubuntu:22.04 |
There was a problem hiding this comment.
Is there any reason why you used ubuntu? If not, could alpine golang be used?
Our proposed solution with alpine golang:
# The purpose of this file is to simply run make commands in deterministic
# environment for those interested in contributing. This is not to be used
# for production purposes.
FROM golang:alpine3.17
RUN apk add make git curl
COPY . /workdir
WORKDIR /workdir
# This is a workaround so that running `make lint` does not result in a
# "error obtaining VCS status: exit status 128" error
RUN go env -w GOFLAGS="-buildvcs=false"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
Dockerfile, which is intended to be used only for development purposes. This also contains amaketarget that allows a user to run any of themakecommands inside of a consistent operating system. This will allow other developers to contribute and build against a similar environment.