Jdk9 support #417
Jdk9 support #417
Conversation
Progress towards JDK9 akhikhl#390.
Progress towards JDK9 akhikhl#390.
Minimum for Groovy on JDK9 is 2.4.12, ref gradle/gradle#2995 . Progress towards JDK9 akhikhl#390.
Progress towards JDK9 akhikhl#390.
|
@javabrett - thanks so much for your work on this! I'm not sure that this is ever going to be merged though as I'm not sure Gretty is still alive. Would you consider forking it and releasing to Maven Central? |
|
@boris-petrov we should hear from @akhikhl who is BDFL. Are you looking for additional collaborators on the project? I typically do not favour creating forks. |
|
@javabrett - I also hate using forks but in this case I don't see any other way. @akhikhl is not responding to any of the issues or pull-requests here so we can assume he isn't going to help with this project any time soon. A lot of people are depending on Gretty so the wisest thing to do is someone else to continue supporting it. Actually the same happened an year or so ago - Gretty was unsupported and we started using another fork of it (which had releases in Maven) and then we switched back to the original when it was resurrected. I see nothing wrong with that - the most important thing is that this project is kept alive. |
|
Noone has heard from @akhikhl since Jun 27 2017 ( #375 (comment) ), so I'm in support for a fork as well. |
|
And the fork should also integrate #415 in order to work with Gradle 4.6. |
|
@javabrett I quickly deleted that comment, it was an error in my config :) |
|
Fork it @javabrett, you're our only hope! You gotta come up with a really good name though. How about Bretty? :) And please also merge my #418 PR if that works for you. |
|
@henrik242 OK that will teach me to reply via email :). Deleted that comment too. |
No need to change the name IMHO. But there's a lot of activity on gretty now, so we should just decide on someone to maintain a fork before all the enthusiasm dwindles... |
|
@woldie @henrik242 @akhikhl I'm not especially interested in taking-up sole-maintainer role of a fork, but obviously happy to contribute. A GitHub Organization seems like a better choice ... and then looking for others to join the cause. Perhaps dependent on that naming, a new plugin Maven package name is required, also assuming @akhikhl can't join and/or yield the current eponymous plugin package-name. |
|
@javabrett @henrik242 @akhikhl I agree that a github organization makes sense. Would be good to share the load and to enable a maintainer to transition ownership to other invested parties once they need to fall off. Yes, I think a rename makes sense - more importantly, I think abandoning the existing Gretty project makes sense, and I move that we agree to do this. "Bretty" is just a fun riff on the old name and keeping the name similar would be an indication to users that Gretty was superceded. And if you found the Github organization, then you should get dibs on the name anyhow. :) Being serious for a moment though, it is tremendously healthy to have a BDFL on these types of projects to point everyone at the architectural north star. Naming after yourself is a good way to establish your turf from the get-go and yet keep it light-hearted. Please consider this. Of course others like myself would be willing to pitch in on approving PR's and be a part of your organization, so you will not be on your own. But, if you wanted to be the front-man, manage releases, and otherwise delegate the work, that could be arranged given how large the community of users is. If fun isn't what we're looking for in a name, then the new name should be very bureaucratic and descriptive. "Tomcat Gradle Plugin" and "Jetty Gradle Plugin", or TGP and JGP. And yes, I'm also suggesting that we separate Gretty into two plugins. This codebase seems a bit tortured at times trying to support both vendors. Once the new plugin is published, we should move ASAP to sunset mentions of gretty in the gradle docs and on plugins.gradle.org in favor of our new plugin. |
|
We can continue the fork discussion in #423 Or at https://github.com/gretty-gradle-plugin/gretty, obviously :) |
|
Hello Guys, Is this change available now? |
Incorporates and supersedes #398. Fixes #390 .