-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utility to setup TLS to make the first developer experience nice #89
Comments
Akka could ship fake certs on the testkit, or there could be a tool to crete a CA and a server cert on the fly. For Lagom we spiked the second alternative and built a |
I think @richdougherty has been working on that, seeing if it is reasonable to use ssl-config here or we can make it convenient some other way. |
Right, I think our approach here should be "whichever style play already does it for dev" :) |
Remember to remove the certs from Quickstarts also, e.g. akka/akka-grpc-quickstart-scala.g8#1 (comment) |
The comment to do what play does still stands, but they what play does does not work very well now: playframework/playframework#8562 would need to be implemented and based on. There's some weird cycles about generating and needing the cert |
For plain Akka to generate the certs we'd need to "steal" code that play has for these things I suppose: from here |
We discussed this some more and concluded that the plain vanilla samples can be without TLS. |
Now that TLS is not required for akka-gRPC I think we'd better close this issue. I would ship the .g8 templates with some sample certificates/keys and maybe some very vague instructions on how to recreate them (with a disclaimer wrt key size, state of art, etc etc) but detailed instructions on relevant details (e.g. subject, authority, ...). Lagom provides in both DevMode and TestKit tools to create fake certificates on the fly. In the case of testkit, there's also an SSLContext baked for the client in tests so it trusts the server in the testkit. I don't think such mechanisms should be part of |
(sorry, pressed the wrong buttons) |
Not entirely sure this is still valid/important, but, related developments #1910 |
We do support non-tls and samples and quickstarts has self-signed certs. |
We should update the quickstarts to use the new cert loading APIs when that is out. |
Either support plain text mode as the Netty client is already doing, or have a utility for setting up dummy test certificates on both sides.
Related akka/akka-http#1849
The text was updated successfully, but these errors were encountered: