Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Harden Integration Tests for AppVersionRevision #1239

Merged
merged 2 commits into from
Dec 12, 2023
Merged

test: Harden Integration Tests for AppVersionRevision #1239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d84d35d
test: Harden Integration Tests for AppVersionRevision
patriknw Dec 11, 2023
c6a0bd7
expected 3 pods when rollout is completed
patriknw Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion integration-test/scripts/app-version-revision-kubernetes-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ testRevisionInPodsLog () {

# the two lines below ensure a rollout is fully completed, before we look at the logs for updated revision
# if not filtering out Terminated or pods that are not not ready (0/1) we will see previous revisions in the logs
[ `kubectl get pods -n $NAMESPACE | grep Terminating | wc -l` -ne 0 ] && continue # loop again until no Terminating nods in the list
[ `kubectl get pods -n $NAMESPACE | grep Running | wc -l` -ne 3 ] && continue # loop again until 3 pods running
[ `kubectl get pods -n $NAMESPACE | grep Terminating | wc -l` -ne 0 ] && continue # loop again until no Terminating pods in the list
[ `kubectl get pods -n $NAMESPACE | grep ContainerCreating | wc -l` -ne 0 ] && continue # loop again until no new pods in the list
[ `kubectl get pods -n $NAMESPACE | grep 0/1 | wc -l` -eq 0 ] && break # exit the loop once we only have READY (1/1) pods
done

Expand Down
Loading