Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider whether VerifiableTimestamp and TimestampCommitment are both needed #102

Closed
sgreenbury opened this issue Jul 17, 2023 · 4 comments
Closed

Consider whether VerifiableTimestamp and TimestampCommitment are both needed #102

sgreenbury opened this issue Jul 17, 2023 · 4 comments

Comments

@sgreenbury
Copy link
Collaborator

sgreenbury commented Jul 17, 2023 •
edited by thobson88
Loading

Qs:

  • VerifiableTimestamp looks very similar to TimestampCommitment; are both needed?
  • the verify_content method in VerifiableTimestamp verifies the expected data in the DID commitment; is this the cleanest way to do it? (at least this is validating the content, not verifying it)
  • why not have VerifiableTimestamp as a trait (without the verify_content method), which is implemented by TimestampCommitment?
  • most importantly, how do we make sure that the validate_pow_hash is called as part of the content verification procedure?

First step will be to draw a diagram of the commitments & related traits.
@thobson88 thobson88 changed the title Consider whether verifiable timestamp and timestamp are both needed Consider whether VerifiableTimestamp and TimestampCommitment are both needed Jul 17, 2023
@thobson88
Copy link
Collaborator

thobson88 commented Jul 19, 2023 •
edited
Loading

UML diagram

Traits in green. Structs in orange.

DID-Verification drawio (2)

@thobson88 thobson88 mentioned this issue Jul 20, 2023
Merged
@thobson88
Copy link
Collaborator

thobson88 commented Jul 20, 2023 •
edited
Loading

Done in PR #105.

VerifiableTimestamp has been turned into a trait, which is a wrapper for a pair of independent commitments, one committing to DID document content and the other to a timestamp.

The verify method in VerifiableTimestamp has a default implementation which verifies each of the two commitments against the same target hash, thereby confirming that the timestamp is immutably associated with the DID document content.

@thobson88
Copy link
Collaborator

thobson88 commented Jul 20, 2023 •
edited
Loading

Updated UML diagram (after refactoring)

refactored-DID-Verification drawio

sgreenbury added a commit that referenced this issue Jul 27, 2023
@sgreenbury
Merge pull request #105 from alan-turing-institute/102-refactor-verif…
e8d344e 
…iable-timestamp

Refactor verifiable timestamp and commitments (#102)
@sgreenbury sgreenbury mentioned this issue Jul 27, 2023
Merged
sgreenbury added a commit that referenced this issue Aug 11, 2023
@sgreenbury
Merge pull request #108 from alan-turing-institute/101-type-state-ver…
9c3f73b 
…ifier

- Type state pattern for `Verifier` with `FullClient` and `LightClient` (#101)
- Refactor of `VerifiableTimestamp` (#102)
- Filtering for block commitments and revised commitment traits with generics (#104)
@sgreenbury
Copy link
Collaborator Author

Closed with #108

@sgreenbury sgreenbury mentioned this issue Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thobson88 @sgreenbury