Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

102 refactor verifiable timestamp #105

Merged
merged 18 commits into from
Jul 27, 2023
Merged

102 refactor verifiable timestamp #105

merged 18 commits into from
Jul 27, 2023

Conversation

thobson88
Copy link
Collaborator

Addresses #102.

@thobson88 thobson88 requested a review from sgreenbury July 20, 2023 03:47
@thobson88
Copy link
Collaborator Author

Unit tests all pass but I haven't run the integration tests yet.

@thobson88 thobson88 mentioned this pull request Jul 20, 2023
Closed
@sgreenbury
Copy link
Collaborator

sgreenbury commented Jul 20, 2023 •
edited
Loading

This looks great, nice one! I've tried the integration tests, a couple of fails:

  • test trustchain_verification
  • test test_verifiable_timestamp

It looks like the verifiable_timestamp.timestamp_commitment().hash() call is not producing the expected hash.

@thobson88
Copy link
Collaborator Author

Would be good to address #104 in here too.

thobson88 and others added 14 commits July 21, 2023 11:34
@thobson88
Fix IONTimestamp construction in IONVerifier
2d66bed
@thobson88
Tidy up & add comments
35a3042
@thobson88
Add PoW hash validation in Verfier::verify()
cf34d2b
@thobson88
Fix warnings; add comments
89fcf41
@thobson88
Make TimestampCommitment a trait, impl in BlockTimestampCommitment wi…
b6fa6b2 
…th filter
@thobson88
Add filter in BlockHashCommitment
ab5ff12
@sgreenbury
Use result type for TimestampCommitment, use sha2 crate
2bd3860
@sgreenbury
Add failing test for block timestamp commitment, fix block hash commi…
2f7902c 
…tment test
@sgreenbury
Remove unused imports
65d3fe4
@sgreenbury
Swap order of args in new method to match other commitments
f01c246
@sgreenbury
Make expected data generic, use in block timestamp commitment
556f122
@sgreenbury
Merge pull request #106 from alan-turing-institute/104-filter-timesta…
89823d0 
…mp-commitment

Add filtering for block hash and timestamp commitments, add generic expected data (#104)
@sgreenbury
Clippy
7385d2d
@sgreenbury
Add doc comment
f003638
@sgreenbury
Copy link
Collaborator

Since #106 is merged and all tests pass, this is ready to merge.

@sgreenbury sgreenbury merged commit e8d344e into 101-type-state-verifier Jul 27, 2023
@sgreenbury sgreenbury deleted the 102-refactor-verifiable-timestamp branch July 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgreenbury sgreenbury Awaiting requested review from sgreenbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thobson88 @sgreenbury