Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type state verifier, refactored verifiable timestamp, filtering for block commitments #108

Merged
merged 43 commits into from
Aug 11, 2023
Merged

Type state verifier, refactored verifiable timestamp, filtering for block commitments #108

merged 43 commits into from
Aug 11, 2023

Conversation

sgreenbury
Copy link
Collaborator

This PR includes:

sgreenbury and others added 28 commits July 13, 2023 14:08
@sgreenbury
Initial refactor
3723a8e
@sgreenbury
Refactor verifier trait implementations, rename types FullClient and …
6020da1 
…LightClient
@thobson88
Improve doc string
0109bf3
@thobson88
Fix doc strings
e9eeeb9
@thobson88
Add function to validate a PoW hash
f905569
@sgreenbury
Add min_zeros config, add todo for failing http test given new error
7c91f1a
@sgreenbury
Update status code for chain resolution with invalid root
0d47d9e
@sgreenbury
Use lib const MIN_ZEROS over config at present
c0c7d5c
@sgreenbury
Refactor test to perform verify call with light client
17d89dd
@thobson88
Make VerifiableTimestamp into a trait
7ac4eea
@thobson88
Use boxed DIDCommitment in IONTimestamp
ca887ac
@thobson88
Fix build errors in Verifier tests
a960d2d
@thobson88
Add comment to VerifiableTimestamp verify method; clean up
fcd6397
@thobson88
Fix IONTimestamp construction in IONVerifier
2d66bed
@thobson88
Tidy up & add comments
35a3042
@thobson88
Add PoW hash validation in Verfier::verify()
cf34d2b
@thobson88
Fix warnings; add comments
89fcf41
@thobson88
Make TimestampCommitment a trait, impl in BlockTimestampCommitment wi…
b6fa6b2 
…th filter
@thobson88
Add filter in BlockHashCommitment
ab5ff12
@sgreenbury
Use result type for TimestampCommitment, use sha2 crate
2bd3860
@sgreenbury
Add failing test for block timestamp commitment, fix block hash commi…
2f7902c 
…tment test
@sgreenbury
Remove unused imports
65d3fe4
@sgreenbury
Swap order of args in new method to match other commitments
f01c246
@sgreenbury
Make expected data generic, use in block timestamp commitment
556f122
@sgreenbury
Merge pull request #106 from alan-turing-institute/104-filter-timesta…
89823d0 
…mp-commitment

Add filtering for block hash and timestamp commitments, add generic expected data (#104)
@sgreenbury
Clippy
7385d2d
@sgreenbury
Add doc comment
f003638
@sgreenbury
Merge pull request #105 from alan-turing-institute/102-refactor-verif…
e8d344e 
…iable-timestamp

Refactor verifiable timestamp and commitments (#102)
@sgreenbury sgreenbury linked an issue Jul 27, 2023 that may be closed by this pull request
Implement type state pattern for IONVerifier #101
Closed
thobson88
thobson88 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@thobson88 thobson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgreenbury sgreenbury merged commit 9c3f73b into main Aug 11, 2023
5 checks passed
@sgreenbury sgreenbury deleted the 101-type-state-verifier branch August 11, 2023 09:57
@sgreenbury sgreenbury mentioned this pull request Aug 11, 2023
Closed
@thobson88 thobson88 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thobson88 thobson88 thobson88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement type state pattern for IONVerifier
2 participants
@sgreenbury @thobson88