feat: add global-option setting in configmap #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sjcsjc123 <[email protected]>
sjcsjc123
requested review from
SpecialYang,
johnlanni,
Charlie17Li and
Xunzhuo
as code owners
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
- Coverage 38.24% 38.11% -0.13%
==========================================
Files 60 61 +1
Lines 9979 10323 +344
==========================================
+ Hits 3816 3935 +119
- Misses 5871 6089 +218
- Partials 292 299 +7
|
Signed-off-by: sjcsjc123 <[email protected]>
|
@sjcsjc123 可以参考下hgctl gateway-config的方式，通过校验envoy配置来做e2e test |
Closed
等pr #710 完成后，我就提供一下e2e测试 |
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
…igmap # Conflicts: # test/e2e/conformance/tests/configmap-global.go
Signed-off-by: sjcsjc123 <[email protected]>
|
cc @2456868764 |
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
Signed-off-by: sjcsjc123 <[email protected]>
2456868764
reviewed
Jan 3, 2024
2456868764
reviewed
Jan 3, 2024
|
LGTM |
johnlanni
approved these changes
Jan 8, 2024
正在补充 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
完善configmap配置
Ⅱ. Does this pull request fix one issue?
fixes #625
fixes #631
fixes #643
Ⅲ. Why don't you add test cases (unit test/integration test)?
暂不知道如何进行测试
Ⅳ. Describe how to verify it
参考gzip/tracing
Ⅴ. Special notes for reviews