Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react lifecycle takes significant time during T playback #191

Open
Tracked by #193 ...
toloudis opened this issue Feb 22, 2024 · 4 comments
Open
Tracked by #193 ...

react lifecycle takes significant time during T playback #191

toloudis opened this issue Feb 22, 2024 · 4 comments

Comments

@toloudis
Copy link
Contributor

Description

Channels arriving triggers extra react state manipulation in callbacks. See channel version being incremented (setOneChannelLoaded) which leads to ChannelUpdater re-render, which has lots of dependencies on version in several useeffects.

Expected Behavior

Hopefully we can find ways to reduce the amount of react cpu processing during T playback.

@toloudis
Copy link
Contributor Author

toloudis commented Jun 3, 2024

of note: close transfer function editors and playback speeds up.

@toloudis
Copy link
Contributor Author

requires profiling and study of how to minimize the work that React is doing when volume data is updated while playback happens.

@toloudis
Copy link
Contributor Author

idea: during playback, figure out what is the minimal stuff that needs to update (e.g. transfer function editor display only when it is open, and nothing else) and create a targeted code path that only updates that stuff ...?

@toloudis
Copy link
Contributor Author

React 18 + production mode can help.
See #247 , #328 , #324 , #322

@toloudis toloudis mentioned this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant