-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 #324
React 18 #324
Conversation
|
…allen-cell-animated/website-3d-cell-viewer into feature/react18perf-functionize
.github/workflows/aws-deploy.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file got autoformatted: the only changes in gh actions workflows are to use node 20 instead of 18
@@ -2,7 +2,7 @@ | |||
|
|||
%axis-override { | |||
/*slider settings*/ | |||
.noUi-handle { | |||
.noUi-horizontal .noUi-handle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes a bug with how slider handles are rendered
mode: "development", | ||
devtool: "eval-source-map", | ||
mode: env.env === "production" ? "production" : "development", | ||
devtool: env.env === "production" ? "source-map" : "eval-source-map", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key change: production mode actually uses production mode. TODO: see how easy it is to debug using source-map in production while still getting higher performance of production mode.
}, | ||
maxEntrypointSize: 3512000, | ||
maxAssetSize: 3512000, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this block cleans up warnings/errors in devServer when testing production mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the max asset size 3.5 MB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we ever exceed it we can just increase these amounts or decide on splitting.. this is just a starting point that makes things work
…nator - Timepoint denominator now matches maximum slider value. - Sorted imports. - Copied a change from #324 which fixes a rendering bug in the slider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always fun to watch React class components get turned into functional ones!
# Conflicts: # package-lock.json
Estimated time to review: 20-30 min?
Most of the changes are converting "class components" to "functional components"
Coauthored with @frasercl
Resolves much of #191 (React lifecycle takes up extra cpu cycles during playback)
Upgrade to React 18, bump some other dependency versions.
Convert to functional components everywhere.
Actually use production mode for production builds.
Some updates to SharedCheckbox
future TODOs clean up some seemingly harmless console warnings:
1.