Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade test for deprecated LibSass to node-sass@5 #5522

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

romaricpascal
Copy link
Member

This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3.

https://github.com/sass/node-sass/releases/tag/v5.0.0

This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3.

https://github.com/sass/node-sass/releases/tag/v5.0.0

Co-authored-by: Brett Kyle <[email protected]>
Co-authored-by: Owen Jones <[email protected]>
@romaricpascal romaricpascal requested a review from a team as a code owner November 21, 2024 17:05
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5522 November 21, 2024 17:06 Inactive
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 42.78 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 92.92 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 87.29 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.18 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.77 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 7.13 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 82.76 KiB 40.37 KiB
accordion.mjs 26.62 KiB 13.41 KiB
button.mjs 9.13 KiB 3.78 KiB
character-count.mjs 25.43 KiB 10.9 KiB
checkboxes.mjs 7.81 KiB 3.42 KiB
error-summary.mjs 11.03 KiB 4.54 KiB
exit-this-page.mjs 20.24 KiB 10.34 KiB
header.mjs 6.46 KiB 3.22 KiB
notification-banner.mjs 9.39 KiB 3.7 KiB
password-input.mjs 18.28 KiB 8.33 KiB
radios.mjs 6.81 KiB 2.98 KiB
service-navigation.mjs 6.44 KiB 3.26 KiB
skip-link.mjs 6.4 KiB 2.76 KiB
tabs.mjs 12.04 KiB 6.67 KiB

View stats and visualisations on the review app


Action run for 04b90a4

@romaricpascal romaricpascal merged commit 0496828 into main Nov 21, 2024
51 checks passed
@romaricpascal romaricpascal deleted the upgrade-old-libsass-test branch November 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants