-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit signal groups in GTKW files #1245
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
==========================================
+ Coverage 90.48% 91.05% +0.57%
==========================================
Files 43 45 +2
Lines 10864 11256 +392
Branches 2660 2449 -211
==========================================
+ Hits 9830 10249 +419
+ Misses 855 828 -27
Partials 179 179 ☔ View full report in Codecov by Sentry. |
@tilk Could you rebase the PR please? We've finally landed |
@tilk, the rework of the simulator necessary for the RFC 36 has introduced some merge conflicts here--could you fix them please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Could you squash the PR please? The commit message could be something like
|
Done. |
Thanks! |
51e0262
Fixes #764.
Things to look at in the review: