This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix: runner failed to start with node 12 images #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogpatch626
approved these changes
Dec 15, 2023
smackfu
approved these changes
Dec 15, 2023
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a general summary of your changes in the Title above.
Description
Describe your changes in detail
when an image provided to the one-app-runner is built with node 12, it would fail to start up.
This is because the flags
--no-experimental-fetchand--dns-result-order=ipv4firstare not valid for node 12.This PR fixes #593 by only adding these flags for versions higher than 5.13.0 of one-app, which is the version that supports node 16.
This was tested against a module and verified the server starts.