Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnicyclePlanner to the list of dependency to disable in CI to check if build works fine anyhow #435

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

traversaro
Copy link
Collaborator

My guess is that this is what silently caused robotology/robotology-superbuild#907 .

@traversaro
Copy link
Collaborator Author

Bingo, the CI fails with:

2021-11-02T13:50:41.3144123Z [ 75%] Building CXX object bindings/python/CMakeFiles/pybind11_blf.dir/bipedal_locomotion_framework.cpp.o
2021-11-02T13:50:41.4343102Z /home/runner/work/bipedal-locomotion-framework/bipedal-locomotion-framework/build/bindings/python/bipedal_locomotion_framework.cpp:32:10: fatal error: BipedalLocomotion/bindings/Planners/Module.h: No such file or directory
2021-11-02T13:50:41.4345580Z    32 | #include <BipedalLocomotion/bindings/Planners/Module.h>
2021-11-02T13:50:41.4346477Z       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-11-02T13:50:41.4347412Z compilation terminated.
2021-11-02T13:50:41.4366276Z make[2]: *** [bindings/python/CMakeFiles/pybind11_blf.dir/build.make:76: bindings/python/CMakeFiles/pybind11_blf.dir/bipedal_locomotion_framework.cpp.o] Error 1
2021-11-02T13:50:41.4371723Z make[1]: *** [CMakeFiles/Makefile2:4173: bindings/python/CMakeFiles/pybind11_blf.dir/all] Error 2
2021-11-02T13:50:41.4381675Z make: *** [Makefile:146: all] Error 2

Exactly like in robotology/robotology-superbuild#907 .

@GiulioRomualdi
Copy link
Member

We need something like this in the bindings

if (FRAMEWORK_COMPILE_Unicycle)

@GiulioRomualdi
Copy link
Member

Or we add the unicycle planner as a dependency if Planner component

What do you think @S-Dafarra @traversaro ?

@S-Dafarra
Copy link
Member

We need something like this in the bindings

if (FRAMEWORK_COMPILE_Unicycle)

Why "compile"?

Or we add the unicycle planner as a dependency if Planner component

What do you think @S-Dafarra @traversaro ?

I guess this was added with #320. So it should be already an optional dependency right?

@GiulioRomualdi
Copy link
Member

MacOS failure related to #685

@GiulioRomualdi GiulioRomualdi merged commit ab9190c into master Jun 15, 2023
@GiulioRomualdi GiulioRomualdi deleted the traversaro-patch-1 branch June 15, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants