Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi: adis16475: Set default trigger #551

Merged
merged 2 commits into from
Apr 17, 2024
Merged

adi: adis16475: Set default trigger #551

merged 2 commits into from
Apr 17, 2024

Conversation

rbolboac
Copy link
Contributor

@rbolboac rbolboac commented Apr 3, 2024

Description

Set default trigger for adis16475 driver

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • OS:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Apr 3, 2024

Test Results

1 468 tests  ±0     272 ✅  - 12   9m 53s ⏱️ -2s
    1 suites ±0   1 196 💤 +12 
    1 files   ±0       0 ❌ ± 0 

Results for commit 8c7ec94. ± Comparison against base commit eba8149.

This pull request skips 12 tests.
test.test_adis16475_p ‑ test_adis16475_attr[accel_x_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[accel_y_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[accel_z_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[anglvel_x_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[anglvel_y_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[anglvel_z_calibbias--2147483648-2147483647-1-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_attr[sample_rate-1000-2000-1000-0-adi.adis16475]
test.test_adis16475_p ‑ test_adis16475_filter_low_pass_3db_frequency
test.test_adis16475_p ‑ test_adis16475_firmware_date
test.test_adis16475_p ‑ test_adis16475_firmware_revision
…

♻️ This comment has been updated with latest results.

@rbolboac
Copy link
Contributor Author

rbolboac commented Apr 3, 2024

HI @tfcollins , is there a way to emulate the triggers of a device? it looks like the emulated test are failing if I add a default trigger in the driver

@rbolboac rbolboac force-pushed the dev/adis16475_trig branch 2 times, most recently from be2b8a3 to 0f8c72d Compare April 3, 2024 09:24
@rbolboac
Copy link
Contributor Author

rbolboac commented Apr 3, 2024

For now, I disabled all tests in emulation mode... because it looks like setting the trigger is not supported in emulation mode.

@rbolboac
Copy link
Contributor Author

rbolboac commented Apr 3, 2024

the build errors do not seem related to these changes

@rbolboac rbolboac requested a review from tfcollins April 3, 2024 10:45
@rbolboac rbolboac force-pushed the dev/adis16475_trig branch from 0f8c72d to 8c7ec94 Compare April 17, 2024 07:01
@rbolboac
Copy link
Contributor Author

  • main rebase

Copy link

Generated documentation for this PR is available at Link

@rbolboac
Copy link
Contributor Author

@tfcollins , is this good to be merged?

@tfcollins tfcollins merged commit 5c7b70e into main Apr 17, 2024
54 checks passed
@tfcollins tfcollins deleted the dev/adis16475_trig branch April 17, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants