Add composition tracing example #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keyboardsurfer I guess the benchmarks fail because of some missing filtering argument? |
|
Yes, feel free to ignore the failing build. We'll fix that in an upcoming PR. |
|
Filed #264 to keep track. |
keyboardsurfer
approved these changes
Nov 27, 2023
| %EntryRow (%Count min 5.0, median 6.0, max 6.0 | ||
| %EntryRow (%Ms min 10.2, median 11.8, max 16.2 | ||
| EntryRowCustomTraceCount min 5.0, median 6.0, max 6.0 | ||
| EntryRowCustomTraceMs min 10.0, median 11.7, max 16.1 |
There was a problem hiding this comment.
Recommend an empty line between startup and frame timing benchmarks. They're hard to distinguish as they are already.
There was a problem hiding this comment.
There are no startup benchmarks 🤔 . I can make a line between the custom traces and frame timing results (just copied it from the outputs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.