-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composition tracing example #263
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
13b6d3c
Update dependencies
mlykotom dd72076
Add dependencies for composition tracing
mlykotom e329d59
Add run configuration stored in the project for easy run
mlykotom 4f0bff6
Use drag instead of fling gesture
mlykotom d91c308
Add readme information on composition tracing
mlykotom b4469e5
Add custom traces + TraceSectionMetric
mlykotom 7559472
Fix composition tracing metric name
mlykotom ded1e1c
Add space
mlykotom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
MacrobenchmarkSample/.run/Scroll List With Composition Tracing.run.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
<component name="ProjectRunConfigurationManager"> | ||
<configuration default="false" name="Scroll List With Composition Tracing" type="AndroidTestRunConfigurationType" factoryName="Android Instrumented Tests"> | ||
<module name="macrobenchmark.macrobenchmark.main" /> | ||
<option name="TESTING_TYPE" value="3" /> | ||
<option name="METHOD_NAME" value="scrollComposeList" /> | ||
<option name="CLASS_NAME" value="com.example.macrobenchmark.benchmark.frames.FrameTimingBenchmark" /> | ||
<option name="PACKAGE_NAME" value="" /> | ||
<option name="TEST_NAME_REGEX" value="" /> | ||
<option name="INSTRUMENTATION_RUNNER_CLASS" value="" /> | ||
<option name="EXTRA_OPTIONS" value="-e androidx.benchmark.perfettoSdkTracing.enable true" /> | ||
<option name="RETENTION_ENABLED" value="No" /> | ||
<option name="RETENTION_MAX_SNAPSHOTS" value="2" /> | ||
<option name="RETENTION_COMPRESS_SNAPSHOTS" value="false" /> | ||
<option name="CLEAR_LOGCAT" value="false" /> | ||
<option name="SHOW_LOGCAT_AUTOMATICALLY" value="false" /> | ||
<option name="INSPECTION_WITHOUT_ACTIVITY_RESTART" value="false" /> | ||
<option name="TARGET_SELECTION_MODE" value="DEVICE_AND_SNAPSHOT_COMBO_BOX" /> | ||
<option name="SELECTED_CLOUD_MATRIX_CONFIGURATION_ID" value="-1" /> | ||
<option name="SELECTED_CLOUD_MATRIX_PROJECT_ID" value="" /> | ||
<option name="DEBUGGER_TYPE" value="Auto" /> | ||
<Auto> | ||
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" /> | ||
<option name="SHOW_STATIC_VARS" value="true" /> | ||
<option name="WORKING_DIR" value="" /> | ||
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" /> | ||
<option name="SHOW_OPTIMIZED_WARNING" value="true" /> | ||
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" /> | ||
<option name="DEBUG_SANDBOX_SDK" value="false" /> | ||
</Auto> | ||
<Hybrid> | ||
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" /> | ||
<option name="SHOW_STATIC_VARS" value="true" /> | ||
<option name="WORKING_DIR" value="" /> | ||
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" /> | ||
<option name="SHOW_OPTIMIZED_WARNING" value="true" /> | ||
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" /> | ||
<option name="DEBUG_SANDBOX_SDK" value="false" /> | ||
</Hybrid> | ||
<Java> | ||
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" /> | ||
<option name="DEBUG_SANDBOX_SDK" value="false" /> | ||
</Java> | ||
<Native> | ||
<option name="USE_JAVA_AWARE_DEBUGGER" value="false" /> | ||
<option name="SHOW_STATIC_VARS" value="true" /> | ||
<option name="WORKING_DIR" value="" /> | ||
<option name="TARGET_LOGGING_CHANNELS" value="lldb process:gdb-remote packets" /> | ||
<option name="SHOW_OPTIMIZED_WARNING" value="true" /> | ||
<option name="ATTACH_ON_WAIT_FOR_DEBUGGER" value="false" /> | ||
<option name="DEBUG_SANDBOX_SDK" value="false" /> | ||
</Native> | ||
<Profilers> | ||
<option name="ADVANCED_PROFILING_ENABLED" value="false" /> | ||
<option name="STARTUP_PROFILING_ENABLED" value="false" /> | ||
<option name="STARTUP_CPU_PROFILING_ENABLED" value="false" /> | ||
<option name="STARTUP_CPU_PROFILING_CONFIGURATION_NAME" value="Java/Kotlin Method Sample (legacy)" /> | ||
<option name="STARTUP_NATIVE_MEMORY_PROFILING_ENABLED" value="false" /> | ||
<option name="NATIVE_MEMORY_SAMPLE_RATE_BYTES" value="2048" /> | ||
</Profilers> | ||
<method v="2"> | ||
<option name="Android.Gradle.BeforeRunTask" enabled="true" /> | ||
</method> | ||
</configuration> | ||
</component> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
#Mon Mar 06 15:40:15 GMT 2023 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend an empty line between startup and frame timing benchmarks. They're hard to distinguish as they are already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no startup benchmarks 🤔 . I can make a line between the custom traces and frame timing results (just copied it from the outputs).