Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a new workflow to validate the FlexibleIPAM feature #6879

Merged
merged 1 commit into from
Feb 10, 2025
Merged

adding a new workflow to validate the FlexibleIPAM feature #6879

merged 1 commit into from
Feb 10, 2025

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Dec 19, 2024 •
edited by rajnkamr
Loading

@KMAnju-2021 KMAnju-2021 marked this pull request as draft December 19, 2024 06:33
@rajnkamr rajnkamr added this to the Antrea v2.3 release milestone Dec 26, 2024
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 22 times, most recently from 33a2b50 to 9486da3 Compare January 2, 2025 04:30
antoninbas
antoninbas reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR is misleading: we are adding a new workflow to validate the FlexibleIPAM feature. The fact that we use a non-default runner is an "implementation detail".

@KMAnju-2021 KMAnju-2021 changed the title [WIP] adding self-hosted runners [WIP] adding a new workflow to validate the FlexibleIPAM feature Jan 3, 2025
@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 10 times, most recently from 689f25e to bee420f Compare February 4, 2025 10:21
antoninbas
antoninbas reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more small comments, but getting there

@KMAnju-2021 KMAnju-2021 force-pushed the add-cncf-runners branch 3 times, most recently from b1b843a to fbdffd6 Compare February 10, 2025 10:08
@KMAnju-2021
adding CNCF runner
6d94347 
Signed-off-by: KMAnju-2021 <[email protected]>
antoninbas
antoninbas approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas
Copy link
Contributor

@KMAnju-2021 any plan to disable / remove the jenkins job after this is merged?

@antoninbas antoninbas merged commit 1f2cf4a into antrea-io:main Feb 10, 2025
60 of 61 checks passed
@antoninbas antoninbas mentioned this pull request Feb 10, 2025
Closed
1 task
@KMAnju-2021 KMAnju-2021 mentioned this pull request Feb 18, 2025
Merged
@XinShuYang XinShuYang added the action/backport Indicates a PR that requires backports. label Feb 19, 2025
@rajnkamr rajnkamr added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Mar 12, 2025
rajnkamr pushed a commit to rajnkamr/antrea that referenced this pull request Mar 12, 2025
@KMAnju-2021 @rajnkamr
Add a new Github workflow to validate FlexibleIPAM (antrea-io#6879)
e101ced 
The workflow is using the runners provided by the CNCF through
the Github Enterprise plan (`ubuntu-latest-4-cores`).

Signed-off-by: KMAnju-2021 <[email protected]>
@rajnkamr rajnkamr mentioned this pull request Mar 12, 2025
Closed
rajnkamr added a commit to rajnkamr/antrea that referenced this pull request Mar 13, 2025
@rajnkamr
Fix issues in cherry-pick of antrea-io#6879
834b155
@rajnkamr rajnkamr mentioned this pull request Mar 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@antoninbas antoninbas antoninbas approved these changes

@Atish-iaf Atish-iaf Awaiting requested review from Atish-iaf

Assignees
No one assigned
Labels
action/backport Indicates a PR that requires backports. kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
4 participants
@KMAnju-2021 @antoninbas @rajnkamr @XinShuYang