Fix glob pattern in codecov action (Kind tests) #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
luolanzone
approved these changes
Feb 22, 2025
|
/skip-all |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
This was referenced Feb 24, 2025
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
that referenced
this pull request
Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619 We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codecov CLI has been updated, and the glob translation logic is different. We need the '**' pattern to match the full path. See codecov/codecov-cli#619
We also remove the trailing wildcard, as it seems that we only ever use the .cov.out suffix for these tests.