Limit azure-servicebus to not be used on ARM #24635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related Azure/azure-uamqp-python#191 |
Cool. I will add t as comment to the setup to track it |
Azure service bus uses uamqp which does not build for ARM architecture and we need to disable it as a dependency for ARM.
potiuk
force-pushed
the
limit-azure-servicebus-to-amd
branch
from
a0016a7 to
dce60ae
Compare
ephraimbuddy
approved these changes
Jun 24, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 26, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example apache#24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
that referenced
this pull request
Jun 26, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example #24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
that referenced
this pull request
Jun 28, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example #24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
that referenced
this pull request
Jun 28, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example #24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
that referenced
this pull request
Jun 28, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example #24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
that referenced
this pull request
Jun 28, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example #24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
Azure service bus uses uamqp which does not build for ARM architecture and we need to disable it as a dependency for ARM. (cherry picked from commit 477f907)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
The image building for ARM is currently only done in the main build only to refresh cache, however there are sometimes cases when new dependency (for example apache#24635) broke ARM image build and it was only discovered after merge. This PR adds extra ARM-based build that should be run after the AMD64 build. It should not influence the depending steps, it should just signal failure of the PR if the ARM image cannot be build. (cherry picked from commit 2fbd750)
ephraimbuddy
added
the
changelog:skip
gracia10
added a commit
to gracia10/airflow-pipline-sample
that referenced
this pull request
Nov 9, 2022
- airflow webserver, ModuleNotFoundError 발생
- | No module named 'azure.servicebus'
- requirements.txt 에 모듈 정보를 추가 했으나 설치 안되어 있음
- `azure-servicebus`는 `uamqp` 모듈에 의존하나
`uamqp`는 ARM 아키텍쳐를 지원하지 않아 설치가 안된것으로 추정
- 참고 apache/airflow#24635
- azure를 사용하지 않아 문구는 무시하고 작업하는 것으로 종결
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure service bus uses uamqp which does not build for ARM architecture
and we need to disable it as a dependency for ARM.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.