Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper inner dependency #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set proper inner dependency #15

wants to merge 1 commit into from

Conversation

alindl
Copy link

@alindl alindl commented May 1, 2021

Setting this dependency, allows maven to do parallel builds, obviously improving building times.
asterix-doc needs at least one file (SQLPP.HTML) that is build by asterix-lang-sqlpp.

Setting this dependency, allows maven to do parallel builds, obviously improving building times.
<dependency>
<groupId>org.apache.asterix</groupId>
<artifactId>asterix-lang-sqlpp</artifactId>
<version>0.9.6-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be ${parent.version} ? We always keep this module's versison the same as the parent's. If it's like this it would complicate the version increment process during releases.

Copy link
Member

@parshimers parshimers Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and by "this" I mean <version>, sorry. I thought that comment would get inserted right at line 52.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure how you do that, I've never really worked with Maven before, but do you mean like that?

Suggested change
<version>0.9.6-SNAPSHOT</version>
<version>${parent.version}</version>

@parshimers
Copy link
Member

Wow! This is great, Thank you.

I tried to get this to work a long time ago, but I guess I was barking up the wrong tree. I thought it was because the javacc-maven-plugin didn't properly support parallel maven execution.

@alindl
Copy link
Author

alindl commented Jun 17, 2021

I just figured that there's an error because asterix-doc just plainly copies stuff from asterix-lang-sqlpp. It's even noted here, so that comment tipped me off, that maybe we need to build asterix-lang-sqlpp before we can copy something from there 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants