-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create devcontainer.json #13520
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken from https://github.com/devcontainers/images/blob/4c7acf3dab33e468bad92e9ef34a70da03453ff2/src/rust/.devcontainer/Dockerfile and added protoc install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taken from https://github.com/devcontainers/images/blob/4c7acf3dab33e468bad92e9ef34a70da03453ff2/src/rust/.devcontainer/devcontainer.json and added the extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rluvaton for your contribution, enabling the CI
FYI, here is the devcontainer I personally use for all my DataFusion development: https://github.com/Omega359/arrow-datafusion/tree/feature/devcontainer/.devcontainer |
Which issue does this PR close?
None
Rationale for this change
Easier contribution
What changes are included in this PR?
Added devcontainer file
Are these changes tested?
yes
Are there any user-facing changes?
No