Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create devcontainer.json #13520

Merged
merged 3 commits into from
Jan 1, 2025
Merged

chore: Create devcontainer.json #13520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a2524c
Create devcontainer.json
rluvaton Nov 21, 2024
c48af3f
update devcontainer
rluvaton Nov 21, 2024
974f5c4
remove useless features
rluvaton Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .devcontainer/Dockerfile
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from https://github.com/devcontainers/images/blob/4c7acf3dab33e468bad92e9ef34a70da03453ff2/src/rust/.devcontainer/Dockerfile and added protoc install

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
FROM rust:bookworm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should document that this exists / how to use dev containers in the documentation. Perhaps at

https://datafusion.apache.org/contributor-guide/getting_started.html#getting-started

We can do it as a follow on PR


RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
# Remove imagemagick due to https://security-tracker.debian.org/tracker/CVE-2019-10131
&& apt-get purge -y imagemagick imagemagick-6-common

# Add protoc
# https://datafusion.apache.org/contributor-guide/getting_started.html#protoc-installation
RUN curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v25.1/protoc-25.1-linux-x86_64.zip \
&& unzip protoc-25.1-linux-x86_64.zip -d $HOME/.local \
&& rm protoc-25.1-linux-x86_64.zip

ENV PATH="$PATH:$HOME/.local/bin"
16 changes: 16 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
rluvaton marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from https://github.com/devcontainers/images/blob/4c7acf3dab33e468bad92e9ef34a70da03453ff2/src/rust/.devcontainer/devcontainer.json and added the extension

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"build": {
"dockerfile": "./Dockerfile",
"context": "."
},
"customizations": {
"vscode": {
"extensions": [
"rust-lang.rust-analyzer"
]
}
},
"features": {
"ghcr.io/devcontainers/features/rust:1": "latest"
}
}