Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: macros crate cleanup #13685

Merged
merged 2 commits into from
Dec 7, 2024
Merged

chore: macros crate cleanup #13685

merged 2 commits into from
Dec 7, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 7, 2024

Which issue does this PR close?

none

Rationale for this change

  • remove unused dependencies
  • move user_doc macro from top-level lib.rs to module (in prep for more macros)

@findepi findepi requested a review from comphead December 7, 2024 18:06
@findepi findepi force-pushed the findepi/remove-unused-dependencies-from-macros-crate-ec6dbb branch 2 times, most recently from 88b2d3c to 6f9faaf Compare December 7, 2024 18:38
@findepi findepi force-pushed the findepi/remove-unused-dependencies-from-macros-crate-ec6dbb branch from 6f9faaf to 32ee6da Compare December 7, 2024 18:40
comphead
comphead approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi for cleaning it up.
Definitely having the code in lib.rs is not a great idea

@comphead comphead mentioned this pull request Dec 7, 2024
Merged
@findepi findepi changed the title macros crate cleanup chore: macros crate cleanup Dec 7, 2024
@findepi findepi merged commit 035fd3b into apache:main Dec 7, 2024
28 checks passed
@findepi findepi deleted the findepi/remove-unused-dependencies-from-macros-crate-ec6dbb branch December 7, 2024 21:13
zhuliquan pushed a commit to zhuliquan/datafusion that referenced this pull request Dec 11, 2024
@findepi @zhuliquan
chore: macros crate cleanup (apache#13685)
3618cfe 
* Remove unused dependencies from macros crate

* rename macro lib to user_doc
@alamb alamb mentioned this pull request Dec 13, 2024
Open
5 tasks
zhuliquan pushed a commit to zhuliquan/datafusion that referenced this pull request Dec 15, 2024
@findepi @zhuliquan
chore: macros crate cleanup (apache#13685)
14dcf20 
* Remove unused dependencies from macros crate

* rename macro lib to user_doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comphead comphead comphead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @comphead