Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor generateExtNameAssignment to better structure #14918

Open
wants to merge 3 commits into
base: 3.3
Choose a base branch
from

Conversation

woosung1223
Copy link

@woosung1223 woosung1223 commented Nov 19, 2024

What is the purpose of the change?

  • Refactored method generateExtNameAssignment in AdaptiveClassCodeGenerator that was TODO commented.
  • Previously, this had the disadvantage of poor visibility of the logic.
  • However, I have improved readability by using ternary operators, but I'm wondering if this is the right direction to go, or if I should refactor it as a method-by-method separation.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@wcy666103
Copy link
Contributor

use mvn spotless:apply to format the code.

@woosung1223
Copy link
Author

@wcy666103 thx a lot, I applied code style. I'm appreciated If you check code changes.

@AlbumenJ
Copy link
Member

Please add some test cases to verify that the results of this method are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants