Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor generateExtNameAssignment to better structure #14918

Open
wants to merge 3 commits into
base: 3.3
Choose a base branch
from
+23 −29
Open

refactor generateExtNameAssignment to better structure #14918

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde35e2
refactor generateExtNameAssignment to better structure
woosung1223 Nov 19, 2024
ebdb551
apply project code style
woosung1223 Nov 19, 2024
6c2ca64
Merge branch '3.3' into refactor-and-remove-todo
AlbumenJ Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 23 additions & 29 deletions dubbo-common/src/main/java/org/apache/dubbo/common/extension/AdaptiveClassCodeGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,44 +269,38 @@ private String generateExtNameNullCheck(String[] value) {
* generate extName assignment code
*/
private String generateExtNameAssignment(String[] value, boolean hasInvocation) {
// TODO: refactor it
String getNameCode = null;

for (int i = value.length - 1; i >= 0; --i) {
if (i == value.length - 1) {
if (null != defaultExtName) {
if (!CommonConstants.PROTOCOL_KEY.equals(value[i])) {
if (hasInvocation) {
getNameCode = String.format(
"url.getMethodParameter(methodName, \"%s\", \"%s\")", value[i], defaultExtName);
} else {
getNameCode = String.format("url.getParameter(\"%s\", \"%s\")", value[i], defaultExtName);
}
} else {
boolean isLastElement = (i == value.length - 1);
boolean isProtocolKey = CommonConstants.PROTOCOL_KEY.equals(value[i]);

if (isLastElement) {
if (defaultExtName != null) {
if (isProtocolKey) {
getNameCode = String.format(
"( url.getProtocol() == null ? \"%s\" : url.getProtocol() )", defaultExtName);
}
} else {
if (!CommonConstants.PROTOCOL_KEY.equals(value[i])) {
if (hasInvocation) {
getNameCode = String.format(
"url.getMethodParameter(methodName, \"%s\", \"%s\")", value[i], defaultExtName);
} else {
getNameCode = String.format("url.getParameter(\"%s\")", value[i]);
}
} else {
getNameCode = "url.getProtocol()";
getNameCode = hasInvocation
? String.format(
"url.getMethodParameter(methodName, \"%s\", \"%s\")", value[i], defaultExtName)
: String.format("url.getParameter(\"%s\", \"%s\")", value[i], defaultExtName);
}
} else {
getNameCode = isProtocolKey
? "url.getProtocol()"
: (hasInvocation
? String.format("url.getMethodParameter(methodName, \"%s\")", value[i])
: String.format("url.getParameter(\"%s\")", value[i]));
}
} else {
if (!CommonConstants.PROTOCOL_KEY.equals(value[i])) {
if (hasInvocation) {
getNameCode = String.format(
"url.getMethodParameter(methodName, \"%s\", \"%s\")", value[i], defaultExtName);
} else {
getNameCode = String.format("url.getParameter(\"%s\", %s)", value[i], getNameCode);
}
} else {
if (isProtocolKey) {
getNameCode = String.format("url.getProtocol() == null ? (%s) : url.getProtocol()", getNameCode);
} else {
getNameCode = hasInvocation
? String.format(
"url.getMethodParameter(methodName, \"%s\", \"%s\")", value[i], defaultExtName)
: String.format("url.getParameter(\"%s\", %s)", value[i], getNameCode);
}
}
}
Expand Down
Loading