Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17915: Convert Kafka Client system tests to use KRaft #17669

Open
wants to merge 34 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-17915: Convert Kafka Client system tests to use KRaft #17669

wants to merge 34 commits into from

Conversation

kirktrue
Copy link
Collaborator

@kirktrue kirktrue commented Nov 2, 2024

Remove the use of Zookeeper as a parameter from tests that create Consumers.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kirktrue
KAFKA-17915: Convert Kafka Client system tests to use KRaft
6de54ea 
Remove the use of Zookeeper as a parameter from tests that create Consumers
@github-actions github-actions bot added the tools label Nov 2, 2024
This was referenced Nov 2, 2024
Merged
Closed
@kirktrue kirktrue added core Kafka Broker kraft KIP-848 The Next Generation of the Consumer Rebalance Protocol clients ci-approved tests Test fixes (including flaky tests) consumer ctr Consumer Threading Refactor (KIP-848) and removed tools labels Nov 2, 2024
@kirktrue kirktrue marked this pull request as ready for review November 2, 2024 23:51
@chia7712
Copy link
Contributor

chia7712 commented Nov 4, 2024

@kirktrue could you please fix conflicts? thanks!

@github-actions github-actions bot added the tools label Nov 4, 2024
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
5f65059
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
023d2de
@kirktrue
Fixed issue with swapped group.id and group.protocol arguments (I ❤️ …
70591d1 
…Python)
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
c71b624
@kirktrue
Fixed ordering of arguments in snapshot_test.py
3f9b78c
@kirktrue
Removed group protocol from ConsoleConsumer as it's not compatible wi…
5d277ae 
…th older versions
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
3a5cd27
@kirktrue
VerifiableConsumer versions <= 3.7.1 are missing --group-protocol option
1786268
@kirktrue
Reverted incorrect use of arrays in @parametrize
627ca9f
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
bb9d778
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
0e039ef
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
b2ccac2
@kirktrue
Reverting breaking change in consumer_rolling_upgrade_test
3db7a76
@kirktrue
Update connect_test.py
fe489c8
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
d5dcfc8
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
20f04b2
@kirktrue
Update Connect system tests to pass in the group protocol via the con…
13b766f 
…nect-distributed.properties
@kirktrue
Discard changes to tests/kafkatest/tests/connect/connect_distributed_…
bd2404e 
…test.py
@kirktrue
Discard changes to tests/kafkatest/tests/connect/templates/connect-di…
c75f34f 
…stributed.properties
@kirktrue
Discard changes to tests/kafkatest/tests/connect/connect_test.py
54363ea
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
fc51248
@kirktrue
Merge branch 'trunk' into KAFKA-17915-remove-zk-from-client-system-tests
084547a
@kirktrue
Removing unnecessary usage of both consumers
c2159d5
@kirktrue
Reverting more changes
d54cdc7
@kirktrue
Reverting more
34ca102
@kirktrue
More reverts
16bbd31
@kirktrue
Reverting yet more
cf28bed
@kirktrue
More reverts
dfd1842
@kirktrue
More reverst
91fc8d6
@github-actions github-actions bot added the small Small PRs label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 Awaiting requested review from chia7712

@lianetm lianetm Awaiting requested review from lianetm

Assignees
No one assigned
Labels
ci-approved clients consumer core Kafka Broker ctr Consumer Threading Refactor (KIP-848) KIP-848 The Next Generation of the Consumer Rebalance Protocol kraft small Small PRs tests Test fixes (including flaky tests) tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirktrue @chia7712