Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager) #13500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods (#create, #createSharedManager)
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
|
heya @slow-J thanks for the PR, and sorry for the delay in reviewing it. I was cleaning things up in this area as well, and ended up making changes to |
|
Thanks @javanna! I fixed the conflicts in |
|
Thanks @slow-J ! |
|
Thanks @javanna for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing usage of TopScoreDocCollector + TopFieldCollector deprecated methods (#create, #createSharedManager)
Addresses #13499
Copying description from issue:
These methods were deprecated in #240 which is part of Lucene 10.0.
Since they are not marked for deprecation in Lucene 9.x, they will not be removed with Lucene 10.0 release (unless we want to deprecate them in 9.x in another backport commit?), but I still think we should remove the internal usage so it will be quicker to remove the methods when the time comes.
This is a 1:1 change to remove the usages.
Test command:
./gradlew clean; ./gradlew tidy; ./gradlew check