validate schemaName must not have double underscore #14511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14511 +/- ##
============================================
+ Coverage 61.75% 63.83% +2.08%
- Complexity 207 1568 +1361
============================================
Files 2436 2672 +236
Lines 133233 146682 +13449
Branches 20636 22493 +1857
============================================
+ Hits 82274 93639 +11365
- Misses 44911 46116 +1205
- Partials 6048 6927 +879
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rohityadav1993
force-pushed
the
master
branch
from
4d44afb
to
44efb13
Compare
Jackie-Jiang
approved these changes
Nov 21, 2024
| @@ -392,6 +392,9 @@ private void validateSchemaName(Schema schema) { | |||
| throw new ControllerApplicationException(LOGGER, | |||
| "Invalid schema. Reason: 'schemaName' should not be null or empty", Response.Status.BAD_REQUEST); | |||
| } | |||
| if (schema.getSchemaName().contains(TableConfig.TABLE_NAME_FORBIDDEN_SUBSTRING)) { | |||
| throw new IllegalStateException("'schemaName' cannot contain double underscore ('__')"); | |||
There was a problem hiding this comment.
Sorry merged it pre-maturely. Can you change this to a ControllerApplicationException?
There was a problem hiding this comment.
Yes, let me raise a PR.
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanupThis PR adds the validation for schemaName to not allow double underscores similar to table name validation.
We don't allow table names with double underscores
__and additionally don't allow tables with schema name different from table name. Schema name validations can help early catching of wrongly named schemas.pinot/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java
Line 144 in 81f16f3
pinot/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
Line 260 in 81f16f3